Skip to content

docs(changelog): note the #4948 stale-approval-card fix - #7094

Merged
nesquena-hermes merged 1 commit into
masterfrom
stage/changelog-231
Aug 16, 2026
Merged

nesquena-hermes merged 1 commit into
masterfrom
stage/changelog-231

Conversation

@nesquena-hermes

Copy link
Copy Markdown
Collaborator

CHANGELOG entry for the approval-mirror request_id fix shipped in #7093 (was merged without a changelog note). Docs-only.

@nesquena-hermes
nesquena-hermes enabled auto-merge (squash) August 16, 2026 22:59
@nesquena-hermes
nesquena-hermes merged commit 53d96fa into master Aug 16, 2026
21 checks passed
@nesquena-hermes
nesquena-hermes deleted the stage/changelog-231 branch August 16, 2026 23:00
@greptile-apps

greptile-apps Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds an Unreleased changelog entry describing the approval-mirror request_id fix shipped in #7093.

Confidence Score: 4/5

The documentation is non-blocking, but the changelog entry should be removed from this standalone PR and left to the release workflow.

The only accepted concern is that this PR directly modifies a file reserved for release commits; no runtime or security behavior is changed.

Files Needing Attention: CHANGELOG.md

Important Files Changed

Filename Overview
CHANGELOG.md Adds an accurate-looking release note, but does so outside the repository’s release-owned changelog workflow.

Reviews (1): Last reviewed commit: "docs(changelog): note the #4948 stale-ap..." | Re-trigger Greptile

Comment thread CHANGELOG.md

### Fixed

- **A stale approval card no longer dead-ends with "Approval response not accepted."** On the local backend, clicking a dangerous-command approval card whose approval had already been resolved or cleared could leave the card stuck showing an error, because WebUI failed to match the resolved approval back to its producer (the agent core delivers the approval as a copy that carries a `request_id` but no `approval_id`, so the existing identity/`approval_id` matches both missed and a tokenless mirror was orphaned). WebUI now also matches on the core's per-approval `request_id`, so a resolved/stale card clears gracefully. (#4948)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Changelog bypasses release ownership

This standalone PR adds an entry directly to CHANGELOG.md, bypassing the repository’s release-owned changelog process and splitting release-note ownership between contributor PRs and release commits; keep the wording in the PR body for the release workflow instead.

Suggested change
- **A stale approval card no longer dead-ends with "Approval response not accepted."** On the local backend, clicking a dangerous-command approval card whose approval had already been resolved or cleared could leave the card stuck showing an error, because WebUI failed to match the resolved approval back to its producer (the agent core delivers the approval as a copy that carries a `request_id` but no `approval_id`, so the existing identity/`approval_id` matches both missed and a tokenless mirror was orphaned). WebUI now also matches on the core's per-approval `request_id`, so a resolved/stale card clears gracefully. (#4948)

Rule Used: Do not flag missing CHANGELOG.md updates on indivi... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

alai04 pushed a commit to alai04/hermes-webui that referenced this pull request Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant