fix(#6906): keep kanban actions reachable in short windows - #7065
Merged
nesquena-hermes merged 4 commits intoAug 16, 2026
Merged
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| static/style.css | Adds shared viewport containment, safe-centering fallback, and internal scrolling for Kanban dialogs. |
| tests/test_issue6906_kanban_modal_height_cap.py | Adds Chromium geometry coverage across locales, viewport sizes, and both Kanban modal consumers. |
| CHANGELOG.md | Describes the short-window Kanban modal usability fix. |
Reviews (3): Last reviewed commit: "docs(changelog): note the #6906 Kanban m..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
nesquena-hermes
added
size:M
nesquena-hermes
enabled auto-merge (squash)
August 16, 2026 23:42
Collaborator
|
Shipped in experimental release exp-v0.52.232 — the Kanban dialogs now cap their height and scroll internally so their action buttons stay reachable in short windows. Codex SAFE + Fable SHIP-UX + Nathan-approved screenshots. Thanks @rodboev! 🤖 Released by the release-manager agent. |
alai04
pushed a commit
to alai04/hermes-webui
that referenced
this pull request
Aug 31, 2026
…esquena#7065) * fix(nesquena#6906): tighten Kanban modal viewport regression * fix(nesquena#6906): preserve modal centering fallbacks * docs(changelog): note the nesquena#6906 Kanban modal height-cap fix --------- Co-authored-by: nesquena-hermes <nesquena+hermes@gmail.com> Co-authored-by: n <a@n>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
What Changed
Why It Matters
Actions stay reachable in short windows; fitting dialogs stay unchanged.
Verification
Base 1280x720 fails and head passes; focused Chromium covers the matrix, CI the full suite.
Risks / Follow-ups
Local proof is Chromium. Pinned actions/body split excluded.
Contract Routing
Task type: UI bug fix.
Touched areas: modal layout/tests.
Relevant public docs:
docs/UIUX-GUIDE.md.Scope boundaries: containment only.
Evidence needed before claiming done: base/head, matrix, lint, screenshots.
Upstream
Closes #6906.
Screenshots
Rendered proof gap: focused headless Chromium geometry checks pass, but before/after screenshots are not hosted in this PR. Visual maintainer sign-off remains outstanding.
Model Used
GPT-5 via Codex CLI, current-tree verified.