Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ RUN apt-get update -y --fix-missing --no-install-recommends \
# https://sqlite.org/wal.html#walresetbug
#
# Debian has not backported the fix, so we compile from the amalgamation.
# Installs to /usr/local/lib (takes ldconfig priority over /usr/lib).
# Installs to /usr/local/lib, which is registered in ld.so.conf.d and given
# priority via ldconfig so Python's sqlite3 loads it ahead of the base image's
# /usr/lib multiarch copy (the default ld.so path does NOT include
# /usr/local/lib on Debian arm64, so the explicit conf entry is required).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Correct the arm64 linker explanation

Debian arm64 includes /usr/local/lib through libc.conf; the problem is that the multiarch configuration sorts earlier and takes precedence. Describing the path as absent obscures the ordering issue that the 000- filename fixes.

Suggested change
# /usr/lib multiarch copy (the default ld.so path does NOT include
# /usr/local/lib on Debian arm64, so the explicit conf entry is required).
# /usr/lib multiarch copy (`aarch64-linux-gnu.conf` sorts before Debian's
# `libc.conf`, so this earlier explicit entry is required).

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

# Build tools are purged after compilation to keep the image lean.
# Build args are for forward version bumps only (3.54+, etc.).
# When bumping SQLITE_VERSION, recompute the SHA-256 from the official
Expand All @@ -56,6 +59,7 @@ RUN apt-get update \
--enable-fts5 --enable-fts4 --enable-rtree \
&& make -j"$(nproc)" \
&& make install \
&& echo "/usr/local/lib" > /etc/ld.so.conf.d/000-usr-local-lib.conf \
&& /sbin/ldconfig \
&& cd / && rm -rf /tmp/sqlite* \
&& apt-get purge -y gcc make libc6-dev \
Expand Down
Loading