fix(i18n): unify ja locale profile wording (プロフィール → プロファイル) - #6762
Conversation
|
| Filename | Overview |
|---|---|
| static/i18n.js | The two Japanese display strings are changed consistently without altering translation keys, interpolation, or runtime behavior. |
Reviews (2): Last reviewed commit: "Merge branch 'master' into fix/ja-profil..." | Re-trigger Greptile
SummaryI reviewed the complete Code referenceAt PR head, settings_title: "設定",
settings_subtitle: "プロフィール、ワークスペース、モデル、API キー、外観を設定します。",
settings_save_failed: "設定の保存に失敗しました: ",
settings_save_success: "プロフィールに設定を保存しました。",The same two legacy spellings are still present on current master at Diagnosis / recommendation
One maintenance note: the PR branch predates a few unrelated additions on master, so the absolute PR-head line numbers are slightly earlier than current master. The three-dot diff contains only these two value changes, and the CI check is green, so that branch lag does not create a review concern for this patch. Test plan
I did not execute code from the untrusted PR worktree. Static inspection and the passing repository check are sufficient for this translation-only change. Verdict: no blocker. |
nesquena-hermes
left a comment
There was a problem hiding this comment.
Gate-clean. Unifies the Japanese locale's two cron 'profile' keys (プロフィール → プロファイル) to match the other 12 ja occurrences and Hermes docs — technical/config profile, not the personal-profile loanword. Codex SAFE TO SHIP (object-level verify: ja keyset unchanged at 1,715 keys, exactly the 2 intended value changes, no other locale touched, node --check + runtime eval pass, no test pins the old spelling). Full suite 14540/0 + 338 i18n + 8 ja-locale tests. Shipping to experimental.
|
Shipped in exp-v0.52.223. Thanks @0809android — nice consistency catch. Verified the whole ja locale now uses プロファイル for config profiles (matching the profiles tab, kanban, and settings, plus the Hermes docs), the key set is unchanged (1,715 keys), no other locale was touched, and no test pinned the old spelling. Gate: Codex object-level diff + full suite + 338 i18n / 8 ja-locale tests, all green. |
…a#6762) Co-authored-by: nesquena-hermes <nesquena+hermes@gmail.com>
nesquena#7026) Co-authored-by: nesquena-hermes <nesquena-hermes@users.noreply.github.com>
What
The Japanese locale used two different spellings for "profile":
プロフィール— only in the cron profile selector keysプロファイル— everywhere else (profiles tab, kanban, settings, etc.)This PR unifies the remaining two keys to
プロファイル, matching the rest of the ja locale and the Hermes docs.Before / After
cron_profile_labelcron_profile_server_default_hintScope
static/i18n.jsja locale only (2 keys). Pure wording change; no behavior change.3f3092a8("feat: add scheduled job profile selector") with theプロフィールspelling.Release note
ja locale: cron profile selector labels now use
プロファイルconsistently.Verification
Local tests were not run in this environment; CI is the verification source of truth.