Skip to content

fix(i18n): unify ja locale profile wording (プロフィール → プロファイル) - #6762

Merged
nesquena-hermes merged 2 commits into
nesquena:masterfrom
0809android:fix/ja-profile-wording
Aug 14, 2026
Merged

nesquena-hermes merged 2 commits into
nesquena:masterfrom
0809android:fix/ja-profile-wording

Conversation

@0809android

Copy link
Copy Markdown
Contributor

What

The Japanese locale used two different spellings for "profile":

  • プロフィール — only in the cron profile selector keys
  • プロファイル — everywhere else (profiles tab, kanban, settings, etc.)

This PR unifies the remaining two keys to プロファイル, matching the rest of the ja locale and the Hermes docs.

Before / After

Key Before After
cron_profile_label プロフィール プロファイル
cron_profile_server_default_hint デフォルトプロフィール / プロフィールのない デフォルトプロファイル / プロファイルのない

Scope

  • static/i18n.js ja locale only (2 keys). Pure wording change; no behavior change.
  • These keys were introduced in 3f3092a8 ("feat: add scheduled job profile selector") with the プロフィール spelling.

Release note

ja locale: cron profile selector labels now use プロファイル consistently.

Verification

Local tests were not run in this environment; CI is the verification source of truth.

@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates two Japanese cron profile translations to use プロファイル, aligning them with the terminology used throughout the rest of the locale.

  • Changes the cron profile selector label.
  • Updates both occurrences in the server-default hint.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
static/i18n.js The two Japanese display strings are changed consistently without altering translation keys, interpolation, or runtime behavior.

Reviews (2): Last reviewed commit: "Merge branch 'master' into fix/ja-profil..." | Re-trigger Greptile

@nesquena-hermes nesquena-hermes added the size:S Small PR (≤2 files, ≤30 LOC) label Aug 5, 2026
@nesquena-hermes

Copy link
Copy Markdown
Collaborator

Summary

I reviewed the complete static/i18n.js file at the PR head and on current origin/master, plus the Japanese-locale contract tests. This is a correct, tightly scoped terminology cleanup. The two edited strings are the remaining Japanese settings entries that use プロファイル; the surrounding profile-management copy consistently uses the standard UI term プロフィール. I do not see a functional or localization blocker.

Code reference

At PR head, static/i18n.js:5153-5157 now reads:

settings_title: "設定",
settings_subtitle: "プロフィール、ワークスペース、モデル、API キー、外観を設定します。",
settings_save_failed: "設定の保存に失敗しました: ",
settings_save_success: "プロフィールに設定を保存しました。",

The same two legacy spellings are still present on current master at static/i18n.js:5178-5180, so the patch changes the intended live strings rather than stale or dead keys. Nearby profile labels and actions at static/i18n.js:3881-3991 use プロフィール, including create, switch, rename, import, and delete copy. That makes this change internally consistent across the locale rather than merely substituting one isolated spelling.

Diagnosis / recommendation

プロフィール is the conventional Japanese transliteration for UI profile concepts and is already the locale convention in this file. The replacement preserves meaning, punctuation, interpolation behavior, and key parity. No JavaScript behavior or cross-locale key shape changes.

One maintenance note: the PR branch predates a few unrelated additions on master, so the absolute PR-head line numbers are slightly earlier than current master. The three-dot diff contains only these two value changes, and the CI check is green, so that branch lag does not create a review concern for this patch.

Test plan

tests/test_japanese_locale.py:97-112 already verifies that the Japanese locale is non-placeholder content and checks representative profile strings. A new test is not necessary for a two-literal copy edit. If maintainers want to make the terminology invariant explicit, a focused assertion that these two settings keys contain プロフィール would prevent reintroduction without over-constraining unrelated translations.

I did not execute code from the untrusted PR worktree. Static inspection and the passing repository check are sufficient for this translation-only change. Verdict: no blocker.

@nesquena-hermes nesquena-hermes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate-clean. Unifies the Japanese locale's two cron 'profile' keys (プロフィール → プロファイル) to match the other 12 ja occurrences and Hermes docs — technical/config profile, not the personal-profile loanword. Codex SAFE TO SHIP (object-level verify: ja keyset unchanged at 1,715 keys, exactly the 2 intended value changes, no other locale touched, node --check + runtime eval pass, no test pins the old spelling). Full suite 14540/0 + 338 i18n + 8 ja-locale tests. Shipping to experimental.

@nesquena-hermes
nesquena-hermes enabled auto-merge (squash) August 14, 2026 16:37
@nesquena-hermes
nesquena-hermes merged commit 155838f into nesquena:master Aug 14, 2026
23 checks passed
nesquena-hermes added a commit that referenced this pull request Aug 14, 2026
Co-authored-by: nesquena-hermes <nesquena-hermes@users.noreply.github.com>
@nesquena-hermes

Copy link
Copy Markdown
Collaborator

Shipped in exp-v0.52.223. Thanks @0809android — nice consistency catch. Verified the whole ja locale now uses プロファイル for config profiles (matching the profiles tab, kanban, and settings, plus the Hermes docs), the key set is unchanged (1,715 keys), no other locale was touched, and no test pinned the old spelling. Gate: Codex object-level diff + full suite + 338 i18n / 8 ja-locale tests, all green.

alai04 pushed a commit to alai04/hermes-webui that referenced this pull request Aug 31, 2026
alai04 pushed a commit to alai04/hermes-webui that referenced this pull request Aug 31, 2026
nesquena#7026)

Co-authored-by: nesquena-hermes <nesquena-hermes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S Small PR (≤2 files, ≤30 LOC)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants