feat(ui): searchable model picker with provider group headers (PR #659 by @mmartial) - #675
Merged
Merged
Conversation
… by @mmartial - Search input at top of model dropdown filters by model name or ID - Provider group headers (Anthropic, OpenAI Codex, OpenRouter, etc.) preserved in filtered view - Clear button resets search; Escape closes dropdown - 'No models found' empty state when nothing matches - i18n: EN, ES, zh-CN strings for search placeholder and no-results - CSS uses var(--accent) consistent with current theme system Also fixes zh-CN double-escaped unicode strings (baab684), and restores provider group headers that were dropped in initial implementation (633e3db). Rebased cleanly onto master; 1423 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searchable model picker (rebase-on-behalf of PR #659 by @mmartial)
This is a clean rebase of @mmartial's #659 onto current master, plus two correctness fixes that were found and addressed during review.
What this adds
Fixes applied during review
zh-CN double-escape bug (commit
baab684on the original PR, reviewed by @nesquena): four zh-CN strings ini18n.jswere double-escaped (\\u81eainstead of\u81ea), causing raw\u...text to render in the Chinese UI. Fixed.Provider group headers regression (identified during integration QA): the initial implementation flattened all models into a
_modelDataarray without storing the group label, so_filterModels()rendered a flat unlabeled list. Fixed by storinggroupon each entry and emitting.model-groupheadings in_filterModels()when the group changes.CSS theme compatibility: the original PR used
rgba(124,185,255,.5)for focus border color. Current master usesvar(--accent)throughout (from the theme system in PR Replace color scheme system with light/dark theme + accent skins #627). Updated to match.Test results
node --checkpasses forstatic/ui.jsandstatic/i18n.jsCloses #659
Co-authored-by: mmartial mmartial@users.noreply.github.com