fix: allow max reasoning for gpt 5.6 - #6353
Draft
dirtydishes wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Hermes already accepts
max, and GPT-5.6 supports it natively. The WebUI’s OpenAI-family ceiling currently stripsmaxfrom every GPT-5 model, so Sol, Terra, and Luna stop atxhigheven though the models can go higher.There are broader PRs open for GPT-5.6 and
ultra, but this one is intentionally boring: no new vocabulary, no catalog changes, no transport changes, and no guessing based on a loosegpt-5.6-*prefix. It only lifts the existing ceiling for the six model IDs Hermes currently knows supportmax.What Changed
-provariant.maxfor those six IDs on OpenAI-family lanes.Why It Matters
The WebUI should not quietly cap a model below a reasoning level the runtime supports. At the same time, capability policy should fail closed instead of handing
maxto every future slug that happens to begin withgpt-5.6-.Contract Routing
Task type: reasoning capability-policy correction.
Touched areas:
Relevant public docs:
AGENTS.mdCONTRIBUTING.mddocs/GUIDELINES.mddocs/CONTRACTS.mddocs/UIUX-GUIDE.mdDESIGN.mdScope boundaries:
ultralevel added.Verification
58 passed424 passedgit diff --check: passed/thermo-nuclear-code-quality-review: APPROVE, no CORE, SILENT, or NIT findings13,324 passed,104 skipped,1 xfailed,2 xpassed;115 failedin unrelated auth/workspace/TLS clustersdd554c17; auth and TLS failures reproduced unchanged, while the sampled workspace/upload tests passed independently (the larger full-suite cluster is state/order-sensitive)Exact reviewed revision:
f8f35b0ab4208f6a3b4c15582e497f4b342737c9dd554c1788948ca5892f549575daf741aa6a88506541d2866d513bef47ff449384d7ec2da2c5d824666df8a72f26a26b5550205dRisks / Follow-ups
maxby name.ultrascope.Release note: GPT-5.6 Sol, Terra, Luna, and Pro variants can now use Max reasoning in the WebUI.
Model Used
gpt-5.6-solfor implementation orchestration, with separate fresh independent and thermo-nuclear review agents.