feat(sidebar): add Claude Code session visibility toggle (#4714)

[rodboev]

Thinking Path

• The sidebar already has a broad Show non-WebUI sessions preference, but the backend importer still exposes a narrower include_claude_code hook that never gets a user-facing setting.
• #4714 is explicitly the focused alternative to the broader multi-origin filter redesign, so the right change is to thread one small subordinate preference through the existing settings and session-import owners.
• The implementation keeps other imported sources untouched while letting users hide Claude Code rows specifically.

What Changed

• api/config.py: add the show_claude_code_sessions default and bool-setting registration.
• api/routes.py: include the new setting in /api/sessions cache-key and builder wiring, keep the helper backward-compatible for older direct callers, and tolerate older get_cli_sessions test doubles while the wider suite stays on the historical signature.
• api/models.py: route the existing include_claude_code hook from the new preference, fold that bit into the lower CLI-session cache key, and keep all-profiles mode scanning global Claude Code history only once.
• static/index.html, static/panels.js, static/i18n.js: add, hydrate, localize, and autosave the subordinate Claude Code visibility checkbox.
• tests/test_issue4714_claude_code_visibility_toggle.py: add route, cache, all-profiles, autosave, live UI-gating, and explicit save-path regression coverage.
• tests/test_1003_preferences_autosave.py: extend Preferences autosave coverage for the new checkbox.

Why It Matters

Users who want to keep Telegram, Discord, cron, or generic CLI sessions visible should not have to hide all non-WebUI sessions just to remove Claude Code imports from the sidebar. This keeps the change narrow and avoids reopening the broader sidebar-filter design work.

Verification

• pytest tests/test_issue4714_claude_code_visibility_toggle.py -v --timeout=60
• pytest tests/test_1003_preferences_autosave.py -v --timeout=60
• pytest tests/test_issue3238_orphaned_cli_sidecar_prune.py tests/test_issue4385_cron_archive_reappears.py tests/test_session_lineage_metadata_api.py tests/test_session_list_long_history_perf.py tests/test_issue4766_sidebar_source_pushdown.py tests/test_issue4775_sidebar_hidden_zero_message_pushdown.py tests/test_1079_cron_session_project.py -v --timeout=60
• eslint --no-config-lookup -c eslint.runtime-guard.config.mjs static/panels.js static/i18n.js
• Full-suite CI context: pytest tests/ -v --timeout=60

Upstream

Closes #4714.

Related context: #3418 already pursues a broader multi-origin filter redesign; this PR keeps the narrower settings-based toggle requested in #4714.

Model Used

OpenAI GPT-5 Codex via Codex CLI

[greptile-apps]

Greptile Summary

This PR adds a subordinate Show Claude Code sessions toggle that lets users hide Claude Code imports from the sidebar without suppressing other non-WebUI sources (Telegram, Discord, cron, webhook). The preference is threaded end-to-end: config default, settings persistence, route cache key, get_cli_sessions filter, and UI checkbox with proper parent-gating.

• Backend: show_claude_code_sessions is registered in _SETTINGS_DEFAULTS (default True) and _SETTINGS_BOOL_KEYS; it's folded into both the route-level session-list cache key and the lower CLI-session cache key so toggling it correctly busts cached results.
• Compatibility shims: _callable_accepts_include_claude_code / _callable_accepts_kwarg use inspect.signature to keep the route working against test doubles that still use the historical two-argument get_cli_sessions signature, replacing the previous exception-swallowing approach.
• Frontend: A new indented checkbox is hydrated from settings, disabled when the parent "Show non-WebUI sessions" toggle is off (independently of the cron checkbox's DOM presence), and persisted without the parent gate so the opt-out preference survives parent toggle changes.

Confidence Score: 5/5

Safe to merge; the change is narrow and well-tested, with no correctness issues on the main path.

All cache key, filter, and UI wiring is correct. The only finding is a defensive-coding inconsistency in the checkbox initializer that won't affect any user with a properly backfilled settings file.

No files require special attention beyond the single-line initializer fix in static/panels.js.

Important Files Changed

Filename	Overview
api/config.py	Adds show_claude_code_sessions default (True) and registers it in _SETTINGS_BOOL_KEYS. Clean and consistent with existing settings patterns.
api/models.py	Adds _callable_accepts_include_claude_code compatibility helper, threads include_claude_code through _resolve_cli_sessions_context and get_cli_sessions, and folds the flag into the lower CLI-session cache key. All-profiles mode correctly limits the global Claude Code scan to the first profile.
api/routes.py	Adds _session_list_cache_key wrapper that appends the Claude Code flag, replaces TypeError-swallowing with inspection-based compatibility, and threads show_claude_code_sessions through the builder and GET handler. Cache key default aligns with the config default (True).
static/panels.js	Hydrates, gates, and autosaves the new checkbox correctly. One inconsistency: show_claude_code_sessions (true-default) is initialized with !! instead of the !== false pattern used for show_cli_sessions and check_for_updates next door.
static/index.html	Adds the Claude Code sessions checkbox as a subordinate indented field after cron sessions, with correct i18n attributes and styling.
static/i18n.js	Adds settings_label_claude_code_sessions and settings_desc_claude_code_sessions in all 14+ locale blocks; non-English locales carry English fallback strings (same pattern as other partially-translated keys in this repo).
tests/test_issue4714_claude_code_visibility_toggle.py	Comprehensive new test file covering route behavior, cache key differentiation, all-profiles deduplication, compatibility shim, autosave payload, live UI gating, and explicit save-path regression.
tests/test_1003_preferences_autosave.py	Extends autosave coverage list with the new checkbox/key pair. Minor doc-comment tidy-up removes the hardcoded field count.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant UI as Browser (panels.js)
    participant Route as /api/sessions (routes.py)
    participant Builder as _build_session_list_cache_payload
    participant Models as get_cli_sessions (models.py)
    participant DB as state.db

    UI->>Route: GET /api/sessions
    Route->>Route: load_settings() → show_claude_code_sessions
    Route->>Route: _session_list_cache_key(..., show_claude_code_sessions) cache hit?
    alt cache miss
        Route->>Builder: _build_session_list_cache_payload(..., show_claude_code_sessions)
        Builder->>Models: "get_cli_sessions(include_claude_code=show_claude_code_sessions)"
        Models->>DB: "_load_cli_sessions_uncached(..., include_claude_code=...)"
        DB-->>Models: rows (filtered or not)
        Models-->>Builder: cli session list
        Builder-->>Route: merged payload
    end
    Route-->>UI: sessions JSON

    Note over UI: loadSettingsPanel() hydrates checkbox
    UI->>UI: onChange → _schedulePreferencesAutosave()
    UI->>Route: "POST /api/settings {show_claude_code_sessions: bool}"

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant UI as Browser (panels.js)
    participant Route as /api/sessions (routes.py)
    participant Builder as _build_session_list_cache_payload
    participant Models as get_cli_sessions (models.py)
    participant DB as state.db

    UI->>Route: GET /api/sessions
    Route->>Route: load_settings() → show_claude_code_sessions
    Route->>Route: _session_list_cache_key(..., show_claude_code_sessions) cache hit?
    alt cache miss
        Route->>Builder: _build_session_list_cache_payload(..., show_claude_code_sessions)
        Builder->>Models: "get_cli_sessions(include_claude_code=show_claude_code_sessions)"
        Models->>DB: "_load_cli_sessions_uncached(..., include_claude_code=...)"
        DB-->>Models: rows (filtered or not)
        Models-->>Builder: cli session list
        Builder-->>Route: merged payload
    end
    Route-->>UI: sessions JSON

    Note over UI: loadSettingsPanel() hydrates checkbox
    UI->>UI: onChange → _schedulePreferencesAutosave()
    UI->>Route: "POST /api/settings {show_claude_code_sessions: bool}"

Loading

_{Reviews (4): Last reviewed commit: "fix(sidebar): preserve Claude Code opt-o..." | Re-trigger Greptile}

[cutter-sh]

🎬 Cutter preview — PR #5213

Toggle Claude Code session visibility — Preferences gain a Show Claude Code sessions toggle, nested under non-WebUI sessions for sidebar filtering.

[nesquena-hermes]

Autonomous triage: Visible sidebar feature (Claude Code session visibility toggle), 691L, CONFLICTING. Concept + screenshot call — parked for Nathan. Rebase deferred until concept greenlit (no point resolving conflicts on an unsanctioned visible feature).

[nesquena-hermes]

🔬 Gate certification — RED ⛔ (well-built; one real preference-stomp — a 2-line fix)

Certified head: sha:3c8d1d9c (rebased onto current master, git apply clean) · PR: #5213 · rodboev, feat(sidebar): add Claude Code session visibility toggle (#4714)
Verdict: Cleanly built and mostly correct (filter is precise, cache-key includes the new param, subordination enforced in the read path), suite green. But the gate found one real SILENT: because Claude Code defaults to visible (opt-out) unlike its opt-in siblings, the save path silently persists it as false when the parent CLI toggle is off — permanently losing the default-visible state. Two-line fix, then ship.

What I ran (rebased worktree /tmp/wt-rebase-5213)

Gate	Result
Rebase onto current master	✅ merge-base == master tip (05aa4731); git apply clean
Codex (reproduce)	SHIP-WITH-FIXES — 2 related SILENT (preference stomp); confirmed by me
Full pytest suite	11423 passed, 0 failed
Filter + cache-key + read-path (mine)	✅ all correct (below)

Findings

✅ Well-built:

• Filter is precisely scoped: if source_filter in (None, CLAUDE_CODE_SOURCE) and include_claude_code: extend(get_claude_code_sessions()) (models.py:5410) — include_claude_code=False skips ONLY claude_code rows; cron/webhook/other CLI sources still flow through. Subordinate to show_cli_sessions.
• Cache-key correct (the Add Webhooks sidebar filter parity #4957 lesson applied): _session_list_cache_key takes show_claude_code_sessions and appends (bool(...),) to the tuple (routes.py:1812/1828), threaded through all call sites — no stale list on toggle.
• Read-path subordination correct: routes.py:2411 show_claude_code_sessions if show_cli_sessions else False.
• Follows the established show_cron/show_webhook toggle pattern; i18n present; suite green.

⛔ SILENT (I REPRODUCED) — preference stomp on an opt-out default (static/panels.js:7693 autosave + :11031 explicit Save): both save paths persist show_claude_code_sessions = (showCli.checked && showClaudeCode.checked). This copies the cron/webhook && showCli idiom (#3514) — which is safe for those because they default to False (opt-in). But Claude Code defaults to True (opt-out), so for a user with show_cli_sessions=false, changing ANY autosaved preference writes show_claude_code_sessions=false even though they never opted out of Claude Code. Then re-enabling CLI sessions leaves Claude Code rows hidden — the default-visible state is silently, permanently lost. The runtime subordination already lives in the read path (routes.py:2411), so gating it again at save time is redundant for enforcement and harmful for an opt-out default.

• Fix (2 lines, Codex-exact): persist the child independently — autosave payload.show_claude_code_sessions = showClaudeCodeCb.checked (drop showCliCb.checked &&); explicit save body.show_claude_code_sessions = showClaudeCodeSessions (drop showCliSessions &&). Keep show_cli_sessions as the parent gate ONLY in the read/filter path (already there). Add a regression: parent-off + toggle-unrelated-pref must not persist the child false.

Recommendation to the next agent

RED — gate-fail/changes-requested, 2-line fix. Everything else is solid (filter scoping, cache-key, read-path subordination, suite green). The fix is to stop baking subordination into the persisted value for this opt-out child (both save paths), keeping it only in the read path. Converges fast. concept 4/5 (Claude Code visibility toggle is a reasonable sidebar-curation feature; maintainer-review label). Author @rodboev (T1). crit=2. Visible sidebar surface — once the fix lands, a quick screenshot of the toggle hiding/showing Claude Code rows would be the last step before merge.

---

Gate-certifier layer (warm-up → gate → release). I do not merge/tag/deploy. Rebased onto current master; the stomp reproduced by reading both save paths + the opt-out default asymmetry. Cert valid for sha:3c8d1d9c.

[rodboev]

Fixed on 2f839397.

1. static/panels.js now persists show_claude_code_sessions directly in both the autosave payload and the explicit Save Settings body, so turning off non-WebUI sessions no longer writes away the default-visible Claude Code preference.
2. The parent gate stays in the read path, where routes.py already suppresses Claude Code rows while show_cli_sessions is off.
3. tests/test_issue4714_claude_code_visibility_toggle.py now locks both save paths against that preference stomp.

[rodboev]

Checked that note against the live settings path. /api/settings serves load_settings(), and load_settings() starts from _SETTINGS_DEFAULTS before overlaying the saved file, so show_claude_code_sessions arrives on the client as a populated key on the normal path. That leaves !!settings.show_claude_code_sessions behaviorally equivalent on this head; the save-path stomp was the real user-facing bug, and 2f839397 fixes that without changing the read-side semantics.

[nesquena-hermes]

🔬 Gate certification — GREEN ✅ · CONVERGED (bounce closed)

Certified head: sha:c5430897 (clean rebase, branch gate-rebase/5213-claude-code-toggle) · PR: #5213 · rodboev, feat(sidebar): add Claude Code session visibility toggle (#4714)
Verdict: Bounce closed — my prior preference-stomp blocker is fixed exactly as specified, and the full gate is clean. Engineering GREEN, ready to merge from the rebase branch (one light pre-merge nicety: a live sidebar screenshot with seeded Claude Code rows; the toggle itself is DOM- and test-verified).

What I ran (rebased worktree /tmp/wt-rebase-5213b, port 8783)

Gate	Result
Rebase onto current master	✅ merge-base == master tip (05aa4731); git apply clean
Codex (reproduce)	SAFE TO SHIP — gated the rebased worktree, 0 findings
Full pytest suite	11423 passed, 0 failed
Toggle + preferences tests	✅ 22/22 (test_issue4714 + test_1003_preferences_autosave)
Live server (8783)	✅ boots on the rebased head; toggle settingsShowClaudeCodeSessions + "Claude Code" label present in served DOM

Findings

✅ CONVERGED — the preference-stomp is fixed (verified byte-exact):
My prior RED: both save paths persisted show_claude_code_sessions = (showCli && showClaudeCode), which stomped the opt-out default to false when the parent CLI toggle was off. The re-push (commit "fix(sidebar): preserve Claude Code opt-out state") applies my exact fix:

• autosave (panels.js:7693): payload.show_claude_code_sessions = showClaudeCodeCb.checked (the showCli && gate removed)
• explicit save (panels.js:11031): body.show_claude_code_sessions = showClaudeCodeSessions (the showCli && gate removed)
• read-path subordination STILL intact (routes.py:2411 show_claude_code_sessions if show_cli_sessions else False) — enforcement preserved, only the persisted value corrected. So the parent gate still hides Claude Code at runtime when CLI is off, but the child's default-visible state is no longer silently lost.

✅ The rest remains solid (re-confirmed on the new head):

• Filter scoping precise: models.py:5410 include_claude_code=False skips only claude_code-source rows; other CLI/cron/webhook sources flow through. Subordinate to show_cli_sessions.
• Cache-key includes show_claude_code_sessions (routes.py:1812/1828) — no stale list on toggle (the Add Webhooks sidebar filter parity #4957 lesson).
• No new regression from the rework commits ("honest wrappers under legacy hooks", "cache keys aligned with webhook-aware filter") — Codex SAFE, suite green.
• i18n keys present; follows the established show_cron/show_webhook toggle pattern.

Recommendation to the next agent

Ready to merge — use branch gate-rebase/5213-claude-code-toggle (sha:c5430897), NOT the PR's stale head 2f839397. Bounce closed cleanly; Codex SAFE + suite 11423/0 + the opt-out fix verified byte-exact with the read-path gate preserved. concept 4/5 (Claude Code sidebar-curation toggle is a reasonable fit; maintainer-review label). Visible surface — a quick sidebar screenshot (with a seeded Claude Code row, toggle off→on) is a nice pre-merge glance for Nathan, but the toggle is DOM-present and behavior is test-verified. Credit @rodboev (T1, co-authored on the rebase). crit=2.

---

Gate-certifier layer (warm-up → gate → release). I do not merge/tag/deploy. Rebased onto current master; the opt-out fix verified byte-exact + read-path gate preserved. Cert valid for sha:c5430897.

[nesquena-hermes]

Shipped in v0.51.816 — thanks @rodboev! 🎉

You can now hide Claude Code sessions from the sidebar independently of other external sessions, via a "Show Claude Code sessions" preference (Settings → Preferences, under "Show non-WebUI sessions", default on). Toggling it persists independently and doesn't disturb the other source-visibility preferences (closes #4714).

Gate: Codex SAFE-TO-SHIP (verified the prior preference-stomp bounce is fixed — the save path persists the child visibility without clobbering siblings, and the read-path gate preserves prior behavior for users who never set it) + full suite 11727 passed + 22/22 targeted + screenshot of the Settings toggle. Rebased onto current master, credit preserved.