Repository navigation
fix(config): reasoning toggle for nested Gemini custom provider routes #4165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+75
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -248,3 +248,38 @@ def test_deepseek_non_reasoning_variants_excluded(model_id): | |||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| # ── custom provider nested Gemini routes (vertex/, gemini_cli/) ─────────────── | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| @pytest.mark.parametrize( | ||||||||||||||||||||||||||||||||||
| "model_id", | ||||||||||||||||||||||||||||||||||
| [ | ||||||||||||||||||||||||||||||||||
| "vertex/gemini-3.1-pro-preview", | ||||||||||||||||||||||||||||||||||
| "vertex/gemini-3-pro-preview", | ||||||||||||||||||||||||||||||||||
| "gemini_cli/gemini-3-pro-preview", | ||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||
| def test_custom_nested_gemini_routes_expose_reasoning(model_id): | ||||||||||||||||||||||||||||||||||
| efforts = cfg.resolve_model_reasoning_efforts( | ||||||||||||||||||||||||||||||||||
| model_id, | ||||||||||||||||||||||||||||||||||
| provider_id="custom:newapi", | ||||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||
| assert set(efforts) >= {"low", "medium", "high"}, ( | ||||||||||||||||||||||||||||||||||
| f"{model_id} via custom:newapi should expose reasoning efforts" | ||||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| @pytest.mark.parametrize( | ||||||||||||||||||||||||||||||||||
| "model_id", | ||||||||||||||||||||||||||||||||||
| [ | ||||||||||||||||||||||||||||||||||
| "vertex/gemini-embedding-001", | ||||||||||||||||||||||||||||||||||
| "vertex/gemini-3-pro-image-preview", | ||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+272
to
+278
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||||||
| def test_custom_nested_gemini_routes_exclude_non_reasoning(model_id): | ||||||||||||||||||||||||||||||||||
| assert cfg.resolve_model_reasoning_efforts( | ||||||||||||||||||||||||||||||||||
| model_id, | ||||||||||||||||||||||||||||||||||
| provider_id="custom:newapi", | ||||||||||||||||||||||||||||||||||
| ) == [], f"{model_id} must not expose reasoning efforts" | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_nested_route_reasoning_deniedand_nested_gateway_route_reasoningeach independently define the same embedding/image/imagine exclusion logic. If a new exclusion pattern (e.g."audio") is added to_nested_gateway_route_reasoningbut not to_nested_route_reasoning_denied, the early-deny guard inresolve_model_reasoning_efforts— which exists specifically to override registry false positives from_models_dev_reasoning_efforts— would silently fail to fire for that new pattern. Extracting the exclusion predicate into a single shared helper (e.g._is_gemini_non_reasoning_tail(tail)) called by both functions would remove the coupling.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!