v0.51.199: pinned-scroll recovery + inline-math currency false-positive - #3353
Merged
Merged
Conversation
…during streaming Codex regression-gate finding: the new requestAnimationFrame retry in _setMessageScrollToBottom re-asserted scrollTop=scrollHeight + _scrollPinned=true on the next layout frame unconditionally, so a user who scrolled up in that ~16ms window during streaming would be snapped back and re-pinned, bypassing the scrollIfPinned early-return guards. Re-check _messageUserUnpinned / upward-intent / non-message-scroll-intent / !_scrollPinned inside the retry; on hit, only release the programmatic-scroll latch and bail.
…sn't read as intent Codex follow-up finding: _lastMessageUpwardIntentMs/_lastNonMessageScrollIntentMs initialized to 0, so _recentMessageUpwardIntent() returned true for the first 2s after load (performance.now() < MESSAGE_UPWARD_INTENT_MS=2000) even with no user scroll — which would disable the new #3319 retry guard during initial load. Sentinel -Infinity makes 'no event recorded yet' read as no-intent. Also tightens the pre-existing scrollIfPinned/settle callers that read the same helpers.
This was referenced Jun 1, 2026
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
v0.51.199: pinned-scroll recovery + inline-math currency false-positive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.51.199 — pinned-scroll recovery + inline-math currency false-positive
Two front-end bug fixes (stage-batch11) — surfaced as new items when their fork CI was approved mid-sweep.
Included PRs
$+digit inline math so currency ($1,000) renders as plain textMaintainer fixes applied (Codex regression gate, 2 rounds)
_messageUserUnpinned/upward-intent/non-message-intent/!_scrollPinned)._lastMessageUpwardIntentMs/_lastNonMessageScrollIntentMsinitialized to0, so the first 2s after page load was misread as user intent (would disable the bug: 发送新消息后聊天内容往上跳约一轮对话高度 #3319 retry on load). Init to-Infinity; also tightens the pre-existingscrollIfPinned/settle callers.Gate results
node -c✓, ESLint runtime gate ✓, no merge markers\(...\)/table-escape paths unaffected;$<digit>trade-off is intentional + test-pinned)