Release DG — stage-batch17 — 9-PR small-fix batch (v0.51.135) - #2944
Merged
Merged
Conversation
_gateway_root_pid_path() unconditionally returned <hermes_root>/gateway.pid. Profile-scoped gateways (started with --profile <name> or via active_profile) write their runtime files under <hermes_root>/profiles/<name>/ instead of the root, so the root-level path never existed. build_agent_health_payload() therefore always received a non-existent pid_path, fell through to the stale root-level gateway_state.json, and returned alive=None. This caused the cron/scheduled-jobs page to display "Gateway not configured" even when a gateway was actively running. Fix: after failing to find a root-level gateway.pid, fall back to the active profile directory via get_active_hermes_home(). Root-level wins when it exists, so deployments that do write there are unaffected. Errors from profile lookup are swallowed and the root path is returned, preserving the previous safe default. Adds five focused unit tests covering the new fallback, the priority rule, and the error-handling path.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
…lable (CI fix)
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
Release DG — stage-batch17 — 9-PR small-fix batch (v0.51.135)
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
Release DG — stage-batch17 — 9-PR small-fix batch (v0.51.135)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release DG / v0.51.135 — stage-batch17 (9 PRs)
Batched release of 9 small, scope-disjoint contributor fixes. All PRs were CI-green individually, all behavioral changes reuse existing helpers, all CHANGELOG entries present.
PRs merged
?session_id=<id>alias for?session=<id>Verification
master..PRandmerge-base..PRdeltasast.parseclean on all .py,node -cclean on changed JS-p no:xdist)[Unreleased]→[v0.51.135]stamped, 6 visible Fixed entries + 1 Added entryCHANGELOG body
Notes for reviewers
This is a small-fix batch — every PR is 1–5 LOC behavioral or a focused test/doc add. No new contracts, no architecture changes, no DB migrations. v0.51.134 from earlier today is unchanged; this batch sits cleanly on top.