fix: render inline formatting in markdown table cells (#273) - #281
Merged
nesquena-hermes merged 1 commit intoApr 12, 2026
Merged
Conversation
Table cells used esc() which escaped all HTML including <strong>, <em>, <code> tags. Changed to inlineMd() which processes markdown bold/italic/code/links and allows safe HTML tags through. This runs after the pre-pass that converts <strong> to ** and <em> to *, so both HTML tags and markdown syntax in table cells are rendered correctly. Fixes #273 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed merge of PR #278 (fix: render inline formatting in markdown table cells).
PR was cut from pre-v0.48.0 master and contained stale-base noise that would have reverted the gateway session sync (PR #274), deleted
test_gateway_sync.py, and rolled back docs to v0.47.1. Cherry-picked only the genuine fix commit (a2ecdca) onto current master.The fix:
esc()→inlineMd()in table cellparseRow/parseHeaderinstatic/ui.js(2 lines). Allows**bold**,*italic*,`code`,[links](url)to render correctly in markdown table cells. Already used for list items and blockquotes.Security:
inlineMd()escapes all interpolated values viaesc(), has aSAFE_INLINEallowlist, and the outerSAFE_TAGSpass at the end ofrenderMd()provides a second layer. XSS test confirmed:<script>alert(1)</script>in a table cell renders as<script>....Tests: 658/658 pass (no regressions). Browser QA confirmed inline formatting renders in table headers and cells.
Closes #273.