Fix Kanban board selector long slug layout - #2525
RajPabnani03 wants to merge 1 commit into
Conversation
SummaryReading
The grid approach is the cleaner design for the long-label problem. The icon-cell PR conflates "icon" with "label" semantics; this PR keeps them separate columns. Code referenceThe new row template at return `<button type="button" class="kanban-board-switcher-item ${isCurrent ? 'is-current' : ''}" role="menuitem" data-board-slug="${esc(b.slug)}" onclick="switchKanbanBoard('${esc(b.slug)}')">
<span class="kanban-board-switcher-item-icon" style="${colorStyle}">${icon || (isCurrent ? '✓' : '')}</span>
<span class="kanban-board-switcher-item-slug" title="${esc(b.slug || '')}">${esc(b.slug || '')}</span>
<span class="kanban-board-switcher-item-name" title="${esc(b.name || b.slug)}">${esc(b.name || b.slug)}</span>
<span class="kanban-board-switcher-item-count">${esc(String(total))}</span>
</button>`;And the grid container at .kanban-board-switcher-item{
display:grid;grid-template-columns:18px minmax(72px,96px) minmax(0,1fr) auto;align-items:center;gap:8px;width:100%;
...
}The new slug chip styling at .kanban-board-switcher-item-slug{
min-width:0;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;
font-family:'SF Mono',ui-monospace,Menlo,monospace;font-size:10px;font-weight:600;
color:var(--accent-text);background:var(--accent-bg);
border:1px solid var(--accent-bg-strong);border-radius:999px;
padding:1px 6px;text-align:center;
}Diagnosis / RecommendationThe change is well-scoped and the design is right. A few notes: 1. PR #2459 conflict. Both PRs touch 2. The 3. 4. The 5. The regression test at Verification
Solid PR. The main open question is the coordination with #2459 — both PRs solve #2458 but with meaningfully different layouts; the maintainer picks one. |
Closing as parallel-discovery superseded by #2459Thanks for the careful work on #2458, @RajPabnani03 — closing this in favor of #2459 which lands the same Kanban board switcher layout fix:
The regression coverage you added in |
Summary
Verification
. .venv-test/bin/activate && python -m pytest tests/test_issue2458_kanban_board_switcher_layout.py tests/test_issue1823_kanban_not_found.py -q: passed (10 passed in 4.69s)Notes