Skip to content

Fix mobile panel touch targets + table cell margin alignment - #2356

Closed
franksong2702 wants to merge 2 commits into
nesquena:masterfrom
franksong2702:franksong2702/issue-2231-mobile-panel-icons
Closed

franksong2702 wants to merge 2 commits into
nesquena:masterfrom
franksong2702:franksong2702/issue-2231-mobile-panel-icons

Conversation

@franksong2702

Copy link
Copy Markdown
Contributor

This PR contains two small UI fixes:

1. Mobile Panel Navigation Touch Targets

  • Expands touch targets for panel navigation icons on phone and tablet
  • Before/after screenshots in docs/pr-media/2231/

2. Table Cell Paragraph Margin Alignment

  • Fixes table cell content appearing misaligned and too spacious
  • The Markdown renderer wraps table cell content in tags which inherited the global rule
  • Added CSS rule to reset margin inside to 0
  • This fixes tables appearing with weird vertical misalignment, especially noticeable on iPad

Testing:

  • ✅ Tables now render correctly on both desktop and mobile
  • ✅ No regression to regular paragraph spacing outside tables

Frank Song added 2 commits May 14, 2026 13:53
- Add rule to reset p margin inside td/th to 0
- Markdown renderer wraps table cell content in <p> tags which inherited
  the global .msg-body p { margin-bottom: 10px } rule, causing extra
  vertical padding inside every table cell
- Fixes table content appearing misaligned and too spacious
@franksong2702
franksong2702 marked this pull request as draft May 16, 2026 04:08
@nesquena nesquena added the hold label May 16, 2026
@franksong2702

Copy link
Copy Markdown
Contributor Author

Closing this draft because it mixed two unrelated scopes: the already-closed #2231 mobile panel navigation work and the separate Markdown table-cell paragraph margin fix. I'll reopen the table spacing fix from a clean branch with only the focused CSS/test changes.

@nesquena-hermes

Copy link
Copy Markdown
Collaborator

Deferred from stage-366 — architectural conflict with current mobile layout

Hey @franksong2702, when I tried to rebase this onto current master, the static/style.css mobile section has a fundamentally different layout strategy than your branch:

  • Current master: uses .sidebar-nav (52px-wide vertical nav rail inside the sidebar, with .panel-view content offset by margin-left:52px).
  • Your branch: uses .rail (52px-wide fixed-positioned rail outside the sidebar, with .main offset and the sidebar slid to left:-mobile-sidebar-width).

These can't both exist — they describe competing mobile shells. Same conflict shape applies to static/panels.js:248 (switchPanel now has new fromRailClick handling) and the mobile-layout tests.

To unblock: please reconcile your touch-target fixes (44×44px minimums, panel button sizing, table cell margin reset) onto the current .sidebar-nav layout rather than the .rail layout your branch introduces. The 44×44px touch-target invariants and the table-cell <p> margin reset are both still valuable; just apply them within the current sidebar-nav structure.

If you'd prefer to keep the .rail-based design as a separate proposal, that's a bigger architectural conversation — file as an issue first.

pull Bot pushed a commit to TKaxv-7S/hermes-webui that referenced this pull request May 16, 2026
v0.51.73 — Release AW:
- PR nesquena#2357 (fixes nesquena#2355) — Compression reference card anchoring fix

The contributor's CHANGELOG entry was wiped during the --ours rebase
conflict resolution (because v0.51.72 stamping moved Unreleased entries
elsewhere). Added the canonical PR-numbered entry manually.

Stage-366 carries only nesquena#2357. Two other recent PRs were deferred:
- nesquena#2347 (live timeline restore, 380 LOC) — real semantic conflicts with
  v0.51.72's nesquena#2348 (_stripLiveVisibleAssistantEchoFromThinking +
  visibleInterimSnippets logic). Needs contributor rebase against current
  master.
- nesquena#2356 (mobile panel touch targets, 98 LOC) — incompatible architectural
  conflicts in static/style.css (.sidebar-nav vs .rail layout choice).
  Needs contributor redesign against current sidebar-nav layout.
SysAdminDoc pushed a commit to SysAdminDoc/hermes-webui that referenced this pull request Jun 26, 2026
v0.51.73 — Release AW:
- PR nesquena#2357 (fixes nesquena#2355) — Compression reference card anchoring fix

The contributor's CHANGELOG entry was wiped during the --ours rebase
conflict resolution (because v0.51.72 stamping moved Unreleased entries
elsewhere). Added the canonical PR-numbered entry manually.

Stage-366 carries only nesquena#2357. Two other recent PRs were deferred:
- nesquena#2347 (live timeline restore, 380 LOC) — real semantic conflicts with
  v0.51.72's nesquena#2348 (_stripLiveVisibleAssistantEchoFromThinking +
  visibleInterimSnippets logic). Needs contributor rebase against current
  master.
- nesquena#2356 (mobile panel touch targets, 98 LOC) — incompatible architectural
  conflicts in static/style.css (.sidebar-nav vs .rail layout choice).
  Needs contributor redesign against current sidebar-nav layout.
bernyforce pushed a commit to bernyforce/hermes-webui that referenced this pull request Jul 29, 2026
v0.51.73 — Release AW:
- PR nesquena#2357 (fixes nesquena#2355) — Compression reference card anchoring fix

The contributor's CHANGELOG entry was wiped during the --ours rebase
conflict resolution (because v0.51.72 stamping moved Unreleased entries
elsewhere). Added the canonical PR-numbered entry manually.

Stage-366 carries only nesquena#2357. Two other recent PRs were deferred:
- nesquena#2347 (live timeline restore, 380 LOC) — real semantic conflicts with
  v0.51.72's nesquena#2348 (_stripLiveVisibleAssistantEchoFromThinking +
  visibleInterimSnippets logic). Needs contributor rebase against current
  master.
- nesquena#2356 (mobile panel touch targets, 98 LOC) — incompatible architectural
  conflicts in static/style.css (.sidebar-nav vs .rail layout choice).
  Needs contributor redesign against current sidebar-nav layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants