[codex] Show skill detail API errors - #2253
Merged
1 commit merged intoMay 14, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
18297f3
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
May 14, 2026
… 0.51.62) (#470) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/nesquena/hermes-webui](https://github.com/nesquena/hermes-webui) | patch | `0.51.61` → `0.51.62` | --- ### Release Notes <details> <summary>nesquena/hermes-webui (ghcr.io/nesquena/hermes-webui)</summary> ### [`v0.51.62`](https://github.com/nesquena/hermes-webui/releases/tag/v0.51.62) [Compare Source](nesquena/hermes-webui@v0.51.61...v0.51.62) ##### What's Changed - stage-355: 11-PR full sweep batch — metadata-only cache hit fixes + skill detail fix + phone UX + escaping + display-title projection + RFC update + test fixture hardening by [@​nesquena-hermes](https://github.com/nesquena-hermes) in [#​2263](nesquena/hermes-webui#2263) - Improve phone sidebar panel navigation by [@​franksong2702](https://github.com/franksong2702) in [#​2238](nesquena/hermes-webui#2238) - fix: reconcile stale sidebar display titles by [@​dso2ng](https://github.com/dso2ng) in [#​2241](nesquena/hermes-webui#2241) - Fix Archive Session for metadata-only cache hits by [@​franksong2702](https://github.com/franksong2702) in [#​2244](nesquena/hermes-webui#2244) - Fix metadata-only cache hits in session mutation routes by [@​franksong2702](https://github.com/franksong2702) in [#​2249](nesquena/hermes-webui#2249) - \[codex] Fix blank skill detail views by [@​franksong2702](https://github.com/franksong2702) in [#​2250](nesquena/hermes-webui#2250) - docs(runtime): codify [#​1925](nesquena/hermes-webui#1925) adapter contract and migration gates by [@​franksong2702](https://github.com/franksong2702) in [#​2251](nesquena/hermes-webui#2251) - \[codex] Show skill detail API errors by [@​franksong2702](https://github.com/franksong2702) in [#​2253](nesquena/hermes-webui#2253) - \[codex] Escape model picker display text by [@​franksong2702](https://github.com/franksong2702) in [#​2255](nesquena/hermes-webui#2255) - \[codex] Fix start.sh dotenv filtering load by [@​franksong2702](https://github.com/franksong2702) in [#​2257](nesquena/hermes-webui#2257) - \[codex] Harden update-link git fixture by [@​franksong2702](https://github.com/franksong2702) in [#​2259](nesquena/hermes-webui#2259) **Full Changelog**: <nesquena/hermes-webui@v0.51.61...v0.51.62> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/470
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
[codex] Show skill detail API errors (franksong2702) # Conflicts: # CHANGELOG.md
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
[codex] Show skill detail API errors (franksong2702) # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
A small quality pass found the Skills detail pane could silently render
(no content)when the API returned HTTP 200 with an error payload such assuccess: false. The backend fix is covered separately by #2250; this PR adds a UI guard so this class of failure is visible instead of looking like empty skill content.What Changed
/api/skills/contentresponses withsuccess: falseorerroras failures before rendering markdown content.erroras failures as well.Why It Matters
This does not replace the backend root-cause fix. It prevents future regressions where a successful HTTP response contains an application-level error and the UI hides that error behind an empty detail pane.
Before / After
Before: API error payload is hidden and the skill looks empty.
After: the same API error is visible in the Skills detail pane.
Verification
node --check static/panels.js/Users/xuefusong/hermes-webui/.venv/bin/pytest tests/test_skill_detail_error_guard.py -qHERMES_HOMEandHERMES_WEBUI_STATE_DIR:origin/master: selected skill rendered(no content)and no visible backend errorNon-relative patterns are unsupportedin the detail paneRisks / Follow-ups
Model Used
GPT-5 Codex. AI assistance was used to inspect, modify, test, and prepare this pull request.