Fix ctl Python wrapper ownership - #2173
Merged
1 commit merged intoMay 13, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
This was referenced May 13, 2026
fdbbb0d
franksong2702
pushed a commit
to franksong2702/hermes-webui-fork
that referenced
this pull request
May 13, 2026
Fix ctl Python wrapper ownership (closes nesquena#2172)
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
Fix ctl Python wrapper ownership (closes nesquena#2172)
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
Fix ctl Python wrapper ownership (closes nesquena#2172)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
PR #2171 exposed a Python 3.13 failure in
tests/test_ctl_script.py. The failure is outside the session-response performance diff:ctl.sh startcan launch a daemon through a customHERMES_WEBUI_PYTHONwrapper, butstatus/stoponly recognize process args containingbootstrap.py,server.py, orstart.sh.What Changed
webui.ctl.envasPYTHON_EXE._is_owned_webui_pid()recognize the recorded Python wrapper path while preserving the existing repo-root state guard.Why It Matters
A daemon started through an explicit Python wrapper should still be treated as the ctl-owned WebUI process. Without this,
statuscan report stopped andstopcan leave the wrapper process running, which is what caused the Python 3.13 CI failure observed from #2171.Verification
uv run --python 3.13 --with pytest --with pytest-timeout pytest -q tests/test_ctl_script.py -vv(4 passed)/Users/xuefusong/hermes-webui/.venv/bin/python -m pytest -q tests/test_ctl_script.py tests/test_ctl_bash32_compat.py(9 passed)bash -n ctl.shgit diff --checkRisks
Low. Ownership still requires the ctl state file and matching repo root before considering either known WebUI entrypoints or the recorded Python executable path.
Related
Closes #2172.
Follow-up from #2171 CI investigation.
Model Used
GPT-5.4 via Codex CLI.