Skip to content

Localize logs severity filters - #2161

Merged
1 commit merged into
nesquena:masterfrom
franksong2702:franksong2702/issue-2098-logs-i18n
May 13, 2026
Merged

1 commit merged into
nesquena:masterfrom
franksong2702:franksong2702/issue-2098-logs-i18n

Conversation

@franksong2702

Copy link
Copy Markdown
Contributor

Thinking Path

Closes #2098. The issue is a narrow localization cleanup for the five Logs severity/filter keys introduced with English fallback TODO placeholders. I kept the patch scoped to those keys rather than translating the broader Logs panel backlog.

What Changed

  • Localized the five Logs severity/filter keys for ja, ru, es, de, zh, zh-Hant, pt, and ko.
  • Removed the affected // TODO: translate placeholders.
  • Added the missing Traditional Chinese entries for these five keys.
  • Added regression coverage that verifies each target locale has the expected localized values and that these key lines no longer carry TODO placeholders.
  • Updated CHANGELOG.md under Unreleased.

Why It Matters

Users running non-English locales should not see English fallback strings in the Logs severity filter UI. This closes the targeted i18n debt from PR #2085 without broadening into unrelated translation TODOs.

Verification

  • /Users/xuefusong/hermes-webui/.venv_test/bin/python -m pytest -q tests/test_issue2098_logs_i18n.py tests/test_login_locale_parity.py
  • node --check static/i18n.js
  • git diff --check

Risks / Follow-ups

Low risk. This is string-only for the targeted Logs severity/filter keys plus a focused regression test. Other existing Logs panel TODO translations remain out of scope for this PR.

Model Used

OpenAI GPT-5.4-Codex

@nesquena-hermes nesquena-hermes closed this pull request by merging all changes into nesquena:master in fdbbb0d May 13, 2026
franksong2702 pushed a commit to franksong2702/hermes-webui-fork that referenced this pull request May 13, 2026
Localize logs severity filters (closes nesquena#2098)

# Conflicts:
#	CHANGELOG.md
SysAdminDoc pushed a commit to SysAdminDoc/hermes-webui that referenced this pull request Jun 26, 2026
Localize logs severity filters (closes nesquena#2098)

# Conflicts:
#	CHANGELOG.md
bernyforce pushed a commit to bernyforce/hermes-webui that referenced this pull request Jul 29, 2026
Localize logs severity filters (closes nesquena#2098)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Localize Logs panel i18n keys (5 keys × 8 non-English locales — TODO placeholders from PR #2085)

2 participants