Skip to content

fix: recover from stale deleted workspaces - #2138

Merged
2 commits merged into
nesquena:masterfrom
dobby-d-elf:fix/stale-workspace-recovery
May 12, 2026
Merged

fix: recover from stale deleted workspaces#2138
2 commits merged into
nesquena:masterfrom
dobby-d-elf:fix/stale-workspace-recovery

Conversation

@dobby-d-elf

@dobby-d-elf dobby-d-elf commented May 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fix workspace fallback logic so WebUI uses the live DEFAULT_WORKSPACE instead of a stale import-time snapshot
  • recover chat sends when an old session points at a deleted workspace and the browser did not explicitly choose that path
  • add regression tests for stale default-workspace fallback and missing-session-workspace recovery

What this fixes

This fixes live Hermes WebUI chats getting stuck with errors like:

Error: Path does not exist: /Users/agent/.hermes/webui-test-.../test-workspace

Root cause:

  • a deleted test workspace path could remain baked into fallback workspace state
  • /api/workspaces could keep serving that stale path when no saved workspace file existed
  • old sessions saved with that dead workspace would fail on the next send instead of recovering

With this change:

  • workspace fallback uses the current runtime default workspace
  • stale implicit session workspaces are repaired to the current valid workspace during chat start

Test Plan

  • Tests added to reproduce this issue in code and passing
  • Also human verified it recovered broken sessions which had this issue.

@nesquena-hermes nesquena-hermes closed this pull request by merging all changes into nesquena:master in 6297443 May 12, 2026
pull Bot pushed a commit to TKaxv-7S/hermes-webui that referenced this pull request May 12, 2026
fix: recover from stale deleted workspaces
SysAdminDoc pushed a commit to SysAdminDoc/hermes-webui that referenced this pull request Jun 26, 2026
fix: recover from stale deleted workspaces
bernyforce pushed a commit to bernyforce/hermes-webui that referenced this pull request Jul 29, 2026
fix: recover from stale deleted workspaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants