fix: expose active run lifecycle in health - #2039
Merged
1 commit merged intoMay 11, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
nesquena-hermes
closed this pull request by merging all changes
into
nesquena:master
in
1483924
plerohellec
pushed a commit
to plerohellec/hermes-webui
that referenced
this pull request
May 11, 2026
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STREAMS.active_runs, per-run metadata/age,oldest_run_age_seconds,last_run_finished_at, and idle grace timing in/health.Why
active_streamsonly describes SSE channel state. A worker can outlive its SSE stream while unwinding, blocked in a provider call, handling cancellation, or waiting on delegated work. Restart/update guards need visibility into worker lifecycle too, otherwise/healthcan look idle while the engine room is still making unpleasant noises.Test Plan
python -m pytest tests/test_run_lifecycle_health.py -q -o 'addopts='python -m py_compile api/config.py api/routes.py api/streaming.pygit diff --checkReview note
A delegated reviewer attempt failed before tool execution with provider-side HTTP 429. I did not count it as approval; this PR has targeted regression tests plus static/security checks.