Fix 1974: trap focus in Kanban modals - #1995
Merged
3 commits merged intoMay 10, 2026
Merged
Conversation
ad290cc
pull Bot
pushed a commit
to JamesWilliam1977/hermes-webui
that referenced
this pull request
May 10, 2026
…ls + status hint by @franksong2702
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
…ls + status hint by @franksong2702
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
…ls + status hint by @franksong2702
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #1974 reports that Kanban's task/board modals do not trap keyboard focus, so Tab can move to underlying page controls while the modal is open.
What changed
_trapModalFocus(modalEl)helper instatic/panels.js._trapModalFocusinto:openKanbanCreate()openKanbanEdit()openKanbanCreateBoard()openKanbanRenameBoard()_kanbanTaskModalFocusCleanup_kanbanBoardModalFocusCleanuptests/test_kanban_ui_static.py:Verification
node --check static/panels.jsnode --check static/ui.jspytest -q tests/test_kanban_ui_static.py(39 passed)pytest -q tests/test_kanban_ui_static.py tests/test_kanban_bridge.py::test_patch_status_running_is_rejected_to_protect_dispatcher_contract tests/test_kanban_bridge.py::test_patch_status_done_to_running_is_rejected(39 passed)Risks
querySelectorAll+ computed styles; edge cases with dynamically injected / hidden controls should still default to the current focus trap behavior.