fix: harden thinking display streaming edge cases - #182
Conversation
Hide partial <think> tag prefixes during streaming and rename the local display variable for clarity. References #181.
|
Agent review — APPROVED ✅ Reviewed by Hermes agent. Full diff, security audit, test suite, QA harness, and browser feature test all completed. Summary: Hardens the thinking/reasoning display path by suppressing partial Diff: 2 files, +46/-1
Test results:
Security audit: CLEAN
Logic correctness: _streamDisplay() All 12 edge cases verified:
renderMessages() think-tag parsing: regex anchored to One design-scope note (not a bug): Browser feature test: PASS Tested on the PR branch (
No console errors observed. No fixes required. The PR is clean, correct, and well-scoped. Safe to merge. |
…ge-cases fix: harden thinking display streaming edge cases
…ge-cases fix: harden thinking display streaming edge cases
Summary
This PR is a standalone follow-up to #181.
It hardens the thinking/reasoning display path in the chat UI by:
<think>/<|channel>thoughtprefixes during streaming so users do not briefly see token fragmentsReference
Test plan
pytest tests/ -x -q(499 passed)