fix: add Docker HEALTHCHECK to Dockerfile - #1332
Closed
zichen0116 wants to merge 1 commit into
Closed
zichen0116 wants to merge 1 commit into
zichen0116 wants to merge 1 commit into
Conversation
The Dockerfile was missing a HEALTHCHECK instruction. Docker and Docker Compose can now automatically detect when the container is healthy using the /health endpoint.
This was referenced Apr 30, 2026
Collaborator
|
Shipped in v0.50.245 via batch release PR #1334 (merge commit Live now at https://github.com/nesquena/hermes-webui/releases/tag/v0.50.245. Released alongside 9 other contributor fixes — see the v0.50.245 entry in CHANGELOG.md. |
bsgdigital
pushed a commit
to bsgdigital/hermes-webui
that referenced
this pull request
Apr 30, 2026
From PR nesquena#1332. Co-authored-by: Leon.C <160379708+zichen0116@users.noreply.github.com>
GeoffBao
pushed a commit
to GeoffBao/hermes-webui
that referenced
this pull request
May 1, 2026
From PR nesquena#1332. Co-authored-by: Leon.C <160379708+zichen0116@users.noreply.github.com>
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
From PR nesquena#1332. Co-authored-by: Leon.C <160379708+zichen0116@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Dockerfile was missing a
HEALTHCHECKinstruction, which means Docker and Docker Compose can't automatically detect when the container is healthy.The
/healthendpoint already exists and returns{"status": "ok"}, so this is a straightforward addition.Changes
Added
HEALTHCHECKinstruction to Dockerfile:This enables:
docker psshows healthy/unhealthy statusdepends_onwithcondition: service_healthyworks