Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add guide for multisig address #3194

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat: Add guide for multisig address #3194

merged 2 commits into from
Jun 25, 2024

Conversation

yanguoyu
Copy link
Collaborator

Refer to Magickbase/neuron-public-issues#401

2024-06-20.18.04.41.mov

@yanguoyu yanguoyu marked this pull request as ready for review June 21, 2024 10:09
@yanguoyu yanguoyu mentioned this pull request Jun 21, 2024
Open
@Danie0918
Copy link
Collaborator

@twhy @homura @devchenyan Please have a review.

homura
homura approved these changes Jun 24, 2024
View reviewed changes
packages/neuron-ui/src/locales/en.json Outdated Show resolved Hide resolved
@silySuper
Copy link
Collaborator

silySuper commented Jun 24, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9638580208. @silySuper

@silySuper
Copy link
Collaborator

https://github.com/nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.

2024-06-24.16.52.21.mov

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Jun 24, 2024 •
edited
Loading

https://github.com/nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.

2024-06-24.16.52.21.mov

I guess the language will take effect after restart the Neuron

@Keith-CY
Copy link
Collaborator

Keith-CY commented Jun 24, 2024 •
edited
Loading

nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.
2024-06-24.16.52.21.mov

I guess the language will take effect after restart the Neuron

Only Chinese/Chinese Simplified are not rendered instantly, other languages are switched as expected in the video

Correct myself, the first time switch to French worked well, other actions didn't

@silySuper
Copy link
Collaborator

https://github.com/nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.
2024-06-24.16.52.21.mov

I guess the language will take effect after restart the Neuron

I found that when I change language and click apply ,the setting can not change.If it changed,language will effect.Does the language change data saved correctly in database after clicking apply button?When restart,it changed.

@silySuper
Copy link
Collaborator

silySuper commented Jun 25, 2024 •
edited
Loading

https://github.com/orgs/Magickbase/projects/6/views/2?pane=issue&itemId=68446485
fix the problem related to this issue

@Keith-CY Keith-CY merged commit 878da3c into nervosnetwork:develop Jun 25, 2024
10 checks passed
@yanguoyu yanguoyu deleted the feat-multi-guide branch June 25, 2024 06:50
This was referenced Aug 8, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@twhy twhy twhy approved these changes

@homura homura homura approved these changes

@silySuper silySuper silySuper approved these changes

@devchenyan devchenyan Awaiting requested review from devchenyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yanguoyu @Danie0918 @silySuper @Keith-CY @twhy @homura