Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Format date when output log. Catch exception when export public key info. #2877

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: Format date when output log. Catch exception when export public key info. #2877

merged 1 commit into from
Oct 18, 2023

Conversation

yanguoyu
Copy link
Collaborator

  1. Format date for electron-log, define for file and console to output unified date.
  2. Sometimes user's DB connection is not opened with an unknown exception, so catch the exception when exporting public key info.

@yanguoyu yanguoyu mentioned this pull request Oct 16, 2023
Closed
@Keith-CY
Copy link
Collaborator

Keith-CY commented Oct 16, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 6530597006. @Keith-CY

@yanguoyu yanguoyu added this pull request to the merge queue Oct 18, 2023
Merged via the queue into nervosnetwork:develop with commit 078b508 Oct 18, 2023
10 checks passed
@yanguoyu yanguoyu deleted the feat-log-time branch October 18, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@devchenyan devchenyan devchenyan approved these changes

@silySuper silySuper silySuper approved these changes

@homura homura Awaiting requested review from homura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanguoyu @Keith-CY @devchenyan @silySuper