-
Notifications
You must be signed in to change notification settings - Fork 84
fix: update dependency jest when to v3 #2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexsupa597
merged 1 commit into
nervosnetwork:develop
from
alexsupa597:fix/update-dependency-jest-when-to-v3
Jun 5, 2023
Merged
fix: update dependency jest when to v3 #2684
alexsupa597
merged 1 commit into
nervosnetwork:develop
from
alexsupa597:fix/update-dependency-jest-when-to-v3
Jun 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanguoyu
reviewed
May 26, 2023
packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts
Show resolved
Hide resolved
packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts
Outdated
Show resolved
Hide resolved
1 task
WhiteMinds
suggested changes
May 29, 2023
4 tasks
WhiteMinds
suggested changes
May 31, 2023
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts
Show resolved
Hide resolved
yanguoyu
approved these changes
May 31, 2023
WhiteMinds
approved these changes
May 31, 2023
packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts
Show resolved
Hide resolved
Conflicted, and please pay attention to the advice at #2684 (comment) |
Updated, Thx |
devchenyan
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As title.
Ref: Magickbase#162
Check List
1、List
2、Detail
Test
e2e Test
Task
none