This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
feat(network): tag consensus peer #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroqn
force-pushed
the
feat-network-tag-consensus-support
branch
from
302da32 to
5ef1ccf
Compare
|
/test chaos |
|
/test all |
zeroqn
force-pushed
the
feat-network-tag-consensus-support
branch
from
5ef1ccf to
17c4119
Compare
|
/test all |
|
/hold |
|
/test all |
|
/test chaos |
zeroqn
force-pushed
the
feat-network-tag-consensus-support
branch
from
a03388c to
af04f0c
Compare
|
/test chaos |
2 similar comments
|
/test chaos |
|
/test chaos |
|
/retest |
|
@zeroqn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
|
/retest |
zeroqn
force-pushed
the
feat-network-tag-consensus-support
branch
2 times, most recently
from
a87eebf to
2eac67d
Compare
…es (nervosnetwork#354) (#2) * change(consensus): replace Validator address bytes with pubkey bytes BREAKING CHANGE: - replace Validator address bytes with pubkey bytes * change(consensus): log validator address instead of its public key Block proposer is address instead public key * fix: compilation failed
* feat(network): move in discovery protocol from forked * feat(network): move in ping protocol * feat(network): move in identify protocol * chore(network): use tentacle from crate * refactor(network): change allow_global_ip feature to global_ip_only * change(network): remove secio_enabled in identify protocol secio should be always enabled in muta network * refactor(network): identify protocol * refactor(network): discovery global_ip_only feature * chore(network): remove garbage files * fix(network): clippy on auto generated code * fix(network): clippy warnings * refactor(nework): ping message use protobuf instead * refactor(network): use protobuf to define discovery message * chore(network): turn off global_ip_only feature by default * refactor(network): define identify message using protobuf * fix(network): clippy warnings * chore(network): remove unused molecule
* refactor(network)!: remove Address, use peer id BREAKING CHANGE: - change users_cast to multicast, take peer_ids bytes instead of Address - network bootstrap configuration now takes peer id instead of pubkey hex * refactor(network): PeerId api
* feat(network): peer tag support * refactor(network): use tag to implement allowlist, ban * fix(network): unit tests * fix(network): peer manager tests * fix(trust_metric_test): update to new network code * fix(network): rebase to latest PR * fix(network): clippy warnings * fix(network): no ban check in tags insert * fix(network): also check Consensus tag instead mixed it with AlwaysAllow
* feat(network): implement tag api * feat: tag consensus peers
zeroqn
force-pushed
the
feat-network-tag-consensus-support
branch
from
2eac67d to
e7175da
Compare
|
/test chaos |
2 similar comments
|
/test chaos |
|
/test chaos |
|
/test all |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yejiayu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it:
Don't share consensus peer info with sync peers
BREAKING CHANGE:
whitelisttoallowlistwhitelist_peer_onlytoallowlist_onlyOther:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: