This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
refactor!(network): rename users_cast to multicast, pass peer_ids instead #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zeroqn
changed the title
zeroqn
force-pushed
the
change-network-api-user-cast
branch
2 times, most recently
from
6ba7383 to
57efc36
Compare
zeroqn
force-pushed
the
change-network-api-user-cast
branch
from
92ff40e to
04090a5
Compare
Change to Hex instead of raw bytes. We don't want to add PeerId to primitive.
Always ensure Hex type contains validate hex string
It's peer id now.
This reverts commit eaf3d32.
zeroqn
force-pushed
the
change-network-api-user-cast
branch
from
3b2fea5 to
1983466
Compare
|
Split this PR. #354 first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
What this PR does / why we need it:
refactor network api
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: