Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent EventHandler::handle_error remove user configured [network].public_addresses #4824

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Prevent EventHandler::handle_error remove user configured [network].public_addresses #4824

wants to merge 1 commit into from
+77 −12

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.
Title Only: Include only the PR title in the release note.
Note: Add a note under the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner March 1, 2025 10:40
@eval-exec eval-exec requested review from doitian and removed request for a team March 1, 2025 10:40
@eval-exec eval-exec force-pushed the exec/public_address_sepearate_config_and_discovered branch 2 times, most recently from 88421c6 to 678c9c2 Compare March 1, 2025 11:02
@eval-exec eval-exec changed the title ckb_network: prevent EventHandler::handle_error removed user configured public_addrs Prevent EventHandler::handle_error removed user configured public_addrs Mar 1, 2025
@eval-exec eval-exec changed the title Prevent EventHandler::handle_error removed user configured public_addrs Prevent EventHandler::handle_error remove user configured public_addrs Mar 1, 2025
@eval-exec eval-exec changed the title Prevent EventHandler::handle_error remove user configured public_addrs Prevent EventHandler::handle_error remove user configured [network].public_addresses Mar 1, 2025
@eval-exec eval-exec force-pushed the exec/public_address_sepearate_config_and_discovered branch from 678c9c2 to 4518a88 Compare March 6, 2025 06:17
@eval-exec eval-exec force-pushed the exec/public_address_sepearate_config_and_discovered branch from 4518a88 to 965ea17 Compare March 6, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eval-exec