feat: small wasm support #4683
Merged
feat: small wasm support #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
small-wasm-support
branch
2 times, most recently
from
7745dd2 to
7b709ad
Compare
quake
reviewed
Oct 24, 2024
driftluo
force-pushed
the
small-wasm-support
branch
14 times, most recently
from
8ac3019 to
b9635a3
Compare
driftluo
force-pushed
the
small-wasm-support
branch
2 times, most recently
from
879ab46 to
e75496e
Compare
doitian
added
the
p:must-have
driftluo
force-pushed
the
small-wasm-support
branch
4 times, most recently
from
052e456 to
e8d79f5
Compare
eval-exec
requested review from
chenyukang,
zhangsoledad and
chaoticlonghair
I don't think it's necessary, ckb itself doesn't release a wasm version |
eval-exec
reviewed
Nov 18, 2024
eval-exec
reviewed
Nov 18, 2024
eval-exec
reviewed
Nov 18, 2024
eval-exec
previously approved these changes
Nov 18, 2024
quake
reviewed
Nov 18, 2024
util/rich-indexer/src/indexer_handle/async_indexer_handle/get_cells.rs
Outdated
Show resolved
Hide resolved
quake
reviewed
Nov 18, 2024
driftluo
force-pushed
the
small-wasm-support
branch
2 times, most recently
from
73c7557 to
db43d25
Compare
quake
reviewed
Nov 19, 2024
quake
reviewed
Nov 19, 2024
quake
reviewed
Nov 19, 2024
driftluo
force-pushed
the
small-wasm-support
branch
from
dbaa473 to
f99e0be
Compare
driftluo
force-pushed
the
small-wasm-support
branch
2 times, most recently
from
e8aab4c to
163fb29
Compare
driftluo
force-pushed
the
small-wasm-support
branch
from
163fb29 to
e300990
Compare
eval-exec
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After some effort, the ckb-light-client project has been verified and run on the browser. It can perform basic queries and responses and can be embedded in any web page. The binary size is about 20M, but there is still some work to be verified. This PR is the basic support for WASM.
wait nervosnetwork/tentacle#375
Issues to discuss：
I disable the peer-store dump on WASM nowload/dump peer store on wasmI disable the network key persistence on WASM nowexport fn to set network key, if not set, return errorCheck List
Tests
Release note