Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace enum FetchCMD by struct FetchCMD #4197

Merged

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

We don't realy need enum FetchCMD to record block fetch task, since it have only one enum item, the suggestion is to use a struct FetchCMD with peers and ibd_state fields. This modification can result in cleaner code.

What is changed and how it works?

What's Changed:

Related changes

  • Replace enum FetchCMD by a struct

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner October 18, 2023 15:20
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team October 18, 2023 15:20
@eval-exec eval-exec added the p:could-have Priority: desirable but not necessary label Oct 18, 2023
@quake quake added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Oct 25, 2023
Merged via the queue into nervosnetwork:develop with commit f8ea3fe Oct 25, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:could-have Priority: desirable but not necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants