Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Consensus.dao_type_hash's Option wrapper #4186

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Remove Consensus.dao_type_hash's Option wrapper #4186

merged 5 commits into from
Oct 12, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 11, 2023 •
edited
Loading

What problem does this PR solve?

The Consensus.dao_type_hash will not be None on mainnet, testnet, and devnet. Removing the Option wrapper will resolve the CI failure on the latest develop branch : https://github.com/nervosnetwork/ckb/commits/develop/.

What is changed and how it works?

  • Remove the Option wrapper for Consensus.dao_type_hash
  • In unit tests: Consensus.dao_type_hash will be Byte32::default()

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner October 11, 2023 09:00
@eval-exec eval-exec requested review from quake and removed request for a team October 11, 2023 09:00
@eval-exec eval-exec added the t:ci Type: CI label Oct 11, 2023
@eval-exec eval-exec self-assigned this Oct 11, 2023
@eval-exec eval-exec mentioned this pull request Oct 11, 2023
Closed
@zhangsoledad zhangsoledad added this pull request to the merge queue Oct 12, 2023
Merged via the queue into nervosnetwork:develop with commit ba31616 Oct 12, 2023
36 checks passed
@doitian doitian mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake quake approved these changes

Assignees

@eval-exec eval-exec

Labels
t:ci Type: CI
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @zhangsoledad