Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cargo update #4168

Merged
merged 2 commits into from
Oct 13, 2023
Merged

chore: cargo update #4168

merged 2 commits into from
Oct 13, 2023

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Sep 21, 2023 •
edited
Loading

What is changed and how it works?

It's been too long since ckb upgraded its dependencies as a whole. #4146 After updating the toolchain, I thought it would be a good time to do a general upgrade of the dependencies to prevent some of them from being outdated.

  • Explicitly allow Unicode License
    the Unicode Data Files and Software License (Unicode-DFS-2016) was designed to be permissive and compatible with open-source licenses like the MIT License.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec added the dependencies Pull requests that update a dependency file label Sep 21, 2023
doitian
doitian requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit PR body

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/update-dep branch from d56de61 to 190e2d6 Compare October 10, 2023 08:36
@zhangsoledad zhangsoledad requested a review from doitian October 10, 2023 08:39
@zhangsoledad zhangsoledad marked this pull request as ready for review October 10, 2023 08:39
@zhangsoledad zhangsoledad requested a review from a team as a code owner October 10, 2023 08:39
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/update-dep branch from 190e2d6 to fb0d7ee Compare October 12, 2023 06:46
@doitian doitian enabled auto-merge October 12, 2023 07:54
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/update-dep branch from 69a1a14 to b0720fd Compare October 13, 2023 03:00
@doitian doitian added this pull request to the merge queue Oct 13, 2023
Merged via the queue into nervosnetwork:develop with commit 5dadcbf Oct 13, 2023
32 of 33 checks passed
This was referenced Oct 13, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@doitian doitian doitian approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @doitian @eval-exec