Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless non_owning_clone method for ChainController and NetworkController #4158

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Remove useless non_owning_clone method for ChainController and NetworkController #4158

merged 2 commits into from
Sep 18, 2023

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

We have remove stop_handler from ChainService and NetworkController in #3999 : related change

So the non_owning_clone become meaningless. Remove it to make code more neat.

What is changed and how it works?

Related changes

  • Remove useless non_owning_clone method for ChainController and NetworkController

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec marked this pull request as ready for review September 16, 2023 06:25
@eval-exec eval-exec requested a review from a team as a code owner September 16, 2023 06:25
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team September 16, 2023 06:25
@doitian doitian added this pull request to the merge queue Sep 18, 2023
Merged via the queue into nervosnetwork:develop with commit 08afa44 Sep 18, 2023
35 checks passed
@doitian doitian mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@quake quake quake approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @doitian