Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse RelayV3's message name for metrics service #4129

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix parse RelayV3's message name for metrics service #4129

merged 1 commit into from
Aug 31, 2023

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

We should parse Relayv3's message name to metrics service.

What's Changed:

Related changes

  • Parse RelayV3's message name

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner August 31, 2023 07:38
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team August 31, 2023 07:38
@eval-exec eval-exec changed the title Fix parse RelayV3 message name for metrics service Fix parse RelayV3's message name for metrics service Aug 31, 2023
@quake quake merged commit e585192 into nervosnetwork:develop Aug 31, 2023
34 checks passed
@eval-exec eval-exec mentioned this pull request Aug 31, 2023
Merged
quake added a commit that referenced this pull request Sep 1, 2023
@quake
Merge pull request #4130 from eval-exec/backport4129
376c0ce 
Backport #4129
@doitian doitian mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @driftluo @quake