Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4097 to rc/v0.111.x #4105

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related issue: #4092

Backport #4097

Problem Summary:

What's Changed:

Related changes

  • let epoch_duration_target affect epoch length when permanent_difficulty_in_dummy is enabled in Dummy mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Note: This PR introduce a breaking change for `Dummy` mode. 
When the CKB is in `Dummy` mode and the `permanent_difficulty_in_dummy` option is set to `true`,
the epoch length will be influenced by the `epoch_duration_target` parameter.
Specifically, the epoch length will be calculated as `epoch_duration_target / 8`. 

For example, if `epoch_duration_target` is configured as `14400`,
the resulting epoch length will be calculated as: `14400` / `8` = `1800`.

@eval-exec eval-exec requested a review from a team as a code owner August 17, 2023 07:53
@zhangsoledad zhangsoledad merged commit a2abcc8 into nervosnetwork:rc/v0.111.x Aug 17, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants