Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus: Add epoch_length_in_dummy param for Dummy mode #4095

Closed
wants to merge 6 commits into from
Closed

Consensus: Add epoch_length_in_dummy param for Dummy mode #4095

wants to merge 6 commits into from

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Aug 10, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4092

Problem Summary:

What is changed and how it works?

Related changes

  • Add epoch_length_in_dummy: u64 param for Consensus, then we can change ckb's epoch length when permanent_difficulty_in_dummy is true.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/config-epoch-length-if-pow-is-dummy branch 5 times, most recently from 1905edf to 0ecb1ed Compare August 10, 2023 12:44
@eval-exec eval-exec added the b:consensus Break consensus label Aug 10, 2023
@eval-exec eval-exec marked this pull request as ready for review August 10, 2023 12:53
@eval-exec eval-exec requested a review from a team as a code owner August 10, 2023 12:53
@eval-exec eval-exec force-pushed the exec/config-epoch-length-if-pow-is-dummy branch from 0da1dfd to 45942d5 Compare August 10, 2023 12:58
@eval-exec eval-exec marked this pull request as draft August 10, 2023 12:58
@eval-exec eval-exec force-pushed the exec/config-epoch-length-if-pow-is-dummy branch from 45942d5 to 2ed8c5c Compare August 10, 2023 14:07
@eval-exec eval-exec marked this pull request as ready for review August 10, 2023 14:26
quake
quake requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@quake quake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #4097 is a better solution, should we close this PR?

@quake quake closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake requested changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

@doitian doitian Awaiting requested review from doitian

@chenyukang chenyukang Awaiting requested review from chenyukang

Assignees
No one assigned
Labels
b:consensus Break consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lock the epoch length in a devchain using mainnet data
2 participants
@eval-exec @quake