feat: add exact search mode #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested review from
zhangsoledad and
doitian
and removed request for
a team
eval-exec
approved these changes
Feb 16, 2023
zhangsoledad
approved these changes
Feb 16, 2023
driftluo
reviewed
Feb 16, 2023
| pub script: Script, | ||
| /// Script Type | ||
| pub script_type: IndexerScriptType, | ||
| /// Script search mode, optional default is `prefix`, means search script with prefix | ||
| pub script_search_mode: Option<IndexerScriptSearchMode>, |
There was a problem hiding this comment.
There are only two states here, null == prefix, and I think #[serde(default)] is a better approach
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
backport nervosnetwork/ckb-indexer#64
Problem Summary: Developer may need to match the exact script for the query in some cases, currently the rpc only has prefix matching, the developer can only get the cells and then filter them on the client side.
What is changed and how it works?
this PR adds the exact match mode.
Check List
Tests
Release note