fix transaction rebroadcast by resubmitting #3840

zhangsoledad · 2023-02-15T15:00:52Z

When a transaction fails a double-spend check, it is still marked as known, making it impossible to rebroadcast by resubmitting

Ensure that if a transaction can be rebroadcast in case of verification failure, it should be removed from the known filter。

Tests

Title Only: Include only the PR title in the release note.

sync/src/types/mod.rs

zhangsoledad requested a review from a team as a code owner February 15, 2023 15:00

zhangsoledad requested review from quake and removed request for a team February 15, 2023 15:00

zhangsoledad force-pushed the zhangsoledad/notify_reject branch from 3f42582 to 92b2286 Compare February 15, 2023 15:47

quake reviewed Feb 16, 2023

View reviewed changes

sync/src/types/mod.rs Outdated Show resolved Hide resolved

zhangsoledad force-pushed the zhangsoledad/notify_reject branch 2 times, most recently from eec4336 to 106e331 Compare February 16, 2023 02:05

driftluo reviewed Feb 16, 2023

View reviewed changes

sync/src/types/mod.rs Outdated Show resolved Hide resolved

zhangsoledad force-pushed the zhangsoledad/notify_reject branch from 106e331 to 5912a84 Compare February 16, 2023 07:42

zhangsoledad added 2 commits February 16, 2023 16:16

fix: improve reject transaction notify

b11f78c

feat: ttl filter

14a41ae

zhangsoledad force-pushed the zhangsoledad/notify_reject branch from 5912a84 to 14a41ae Compare February 16, 2023 08:16

driftluo approved these changes Feb 16, 2023

View reviewed changes

zhangsoledad added this pull request to the merge queue Feb 26, 2023

Merged via the queue into nervosnetwork:develop with commit 1ba4ba6 Feb 26, 2023

doitian mentioned this pull request Apr 13, 2023

Release ckb v0.109.0 #3918

Closed

3 tasks

Provide feedback