fix: notify message blocking #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/notify
branch
2 times, most recently
from
0b8b35d
to
9dff28b
Compare
quake
reviewed
Dec 10, 2022
zhangsoledad
force-pushed
the
zhangsoledad/notify
branch
from
9dff28b
to
841a1b3
Compare
zhangsoledad
force-pushed
the
zhangsoledad/notify
branch
from
841a1b3
to
f4e20df
Compare
quake
approved these changes
Dec 10, 2022
|
bors r+ |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Notify service is essentially a message bus, which should push messages to subscribers in non-blocking form, and push to subscribers should be treated as a remote call, so the timeout setting should be added.
Check List
Tests
Release note