fix(light-client): do not skip the genesis block for last state proofs #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
commented
Nov 9, 2022
| assert!(result.is_ok(), "failed since {}", result.unwrap_err()); | ||
| result.unwrap() | ||
| }; | ||
| let result = proof.verify(parent_chain_root, digests_with_positions); |
There was a problem hiding this comment.
Without the fix, this line will throw the error "Corrupted proof".
yangby-cryptape
force-pushed
the
pr/fix-should-not-skip-genesis-in-proof
branch
from
7d992be
to
fe07559
Compare
yangby-cryptape
requested review from
doitian,
TheWaWaR and
quake
and removed request for
a team and
doitian
TheWaWaR
approved these changes
Nov 10, 2022
quake
approved these changes
Nov 10, 2022
|
bors merge |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Should not skip the genesis block for last state proofs.
For example, when current tip header at 1, then the last state proof have to contain the genesis block.
What is changed and how it works?
Since #3675, the genesis block will use a default struct as its parent chain root, so we don't have to skip it anymore.
ckb/util/light-client-protocol-server/src/lib.rs
Lines 125 to 127 in 5aa8b42
And, for more security, we should check if the parent chain root of a genesis block is a default struct.
Check List
Tests
Release note