Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rpc estimate_cycles #3669

Merged

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

An new RPC to run the transaction and return cycles.

What is changed and how it works?

estimate_cycles is essentially a renaming of the previous dry_run_transaction, which was then moved from Experiment to Chain module, with the original dry_run_transaction retained and marked as deprecated.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner October 28, 2022 04:37
@zhangsoledad zhangsoledad requested review from quake and removed request for a team October 28, 2022 04:37
@zhangsoledad
Copy link
Member Author

bors r+

@bors bors bot merged commit 838e2ab into nervosnetwork:develop Oct 28, 2022
@doitian doitian mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants