Skip to content

feat: add tcp and websocket to rpc service#1882

Merged
bors[bot] merged 2 commits into
developfrom
quake/rpc-server
Dec 24, 2019
Merged

feat: add tcp and websocket to rpc service#1882
bors[bot] merged 2 commits into
developfrom
quake/rpc-server

Conversation

@quake
Copy link
Copy Markdown
Member

@quake quake commented Dec 17, 2019

This PR adds tcp and websocket support for rpc, this is required for #1867

test tcp:

telnet localhost 18114
> {"id":2,"jsonrpc":"2.0","method":"get_tip_block_number","params":[]}
< {"jsonrpc":"2.0","result":"0x337e","id":2}

test websocket:

let socket = new WebSocket("ws://localhost:28114");
socket.onmessage = function(event) {
  console.log(`Data received from server: ${event.data}`);
};
socket.send('{"id":2,"jsonrpc":"2.0","method":"get_tip_block_number","params":[]}');

@quake quake requested a review from a team December 17, 2019 10:27
Comment thread rpc/src/test.rs
bors Bot added a commit that referenced this pull request Dec 23, 2019
@nervosnetwork nervosnetwork deleted a comment from bors Bot Dec 23, 2019
@quake
Copy link
Copy Markdown
Member Author

quake commented Dec 23, 2019

bors try

bors Bot added a commit that referenced this pull request Dec 23, 2019
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Dec 23, 2019

try

Build succeeded

  • continuous-integration/travis-ci/push

@doitian
Copy link
Copy Markdown
Member

doitian commented Dec 24, 2019

bors r=doitian,keroro520

@nervos-bot nervos-bot Bot added the s:ready-to-merge Status: Waiting to be merged. label Dec 24, 2019
bors Bot added a commit that referenced this pull request Dec 24, 2019
1882: feat: add tcp and websocket to rpc service r=doitian,keroro520 a=quake

This PR adds tcp and websocket support for rpc, this is required for #1867 

test tcp:
```shell
telnet localhost 18114
> {"id":2,"jsonrpc":"2.0","method":"get_tip_block_number","params":[]}
< {"jsonrpc":"2.0","result":"0x337e","id":2}
```

test websocket:
```javascript
let socket = new WebSocket("ws://localhost:28114");
socket.onmessage = function(event) {
  console.log(`Data received from server: ${event.data}`);
};
socket.send('{"id":2,"jsonrpc":"2.0","method":"get_tip_block_number","params":[]}');
```

Co-authored-by: quake wang <quake.wang@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Dec 24, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors Bot merged commit 5d2361c into develop Dec 24, 2019
@bors bors Bot deleted the quake/rpc-server branch December 24, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s:ready-to-merge Status: Waiting to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants