Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Indexer DB options #3696

Closed
zhangsoledad opened this issue Nov 9, 2022 · 2 comments
Closed

Improve Indexer DB options #3696

zhangsoledad opened this issue Nov 9, 2022 · 2 comments
Labels
t:enhancement Type: Feature, refactoring.

Comments

@zhangsoledad
Copy link
Member

Previously, #3681 added db options for indexer, but the options of ckb db is not suitable to apply directly to indexer, for example, indexer does not use columns.

https://discord.com/channels/870891180035031071/871660793333182504/1039794244837187604
A issue was reported, most likely due to the indexer's db compation not being able to keep up, the solution to this is also very simple just set max_background_compactions
max_background_flushes or max_background_jobs can be solved.
@zhangsoledad zhangsoledad added the t:enhancement Type: Feature, refactoring. label Nov 9, 2022
@driftluo driftluo mentioned this issue Nov 30, 2022
Closed
@zhangsoledad zhangsoledad mentioned this issue Dec 2, 2022
Merged
bors bot added a commit that referenced this issue Dec 6, 2022
@bors @zhangsoledad
Merge #3735
9ebc667 
3735: feat: indexer db simple configuration r=zhangsoledad a=zhangsoledad

<!--
Thank you for contributing to nervosnetwork/ckb!

If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two.

PR Title Format:
1. module [, module2, module3]: what's changed
2. *: what's changed
-->

### What problem does this PR solve?
Resolve configuration issues with Indexer db
#3696
#3730


### What is changed and how it works?

the RocksDB debug log is not really of much use to the average user, just setting keep_log_file_num to 1 (0 is not allowed). only maintain a single LOG file which is probably the cleanest and simplest solution.

I don't  introduce `FullOptions::load_from_file` here, because `FullOptions::load_from_file` is also a legacy dirty patch, and users don't want to see all the configuration items of rocksdb in front of them and have no idea what they can do, so for now we'll just provide the simplest and most useful options.

### Related changes

- PR to update `owner/repo`:
- Need to cherry-pick to the release branch

### Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

- Unit test
- Integration test


### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. -->

```release-note
Title Only: Include only the PR title in the release note.
```



Co-authored-by: zhangsoledad <[email protected]>
@chenyukang
Copy link
Collaborator

@zhangsoledad this issue is outdate since #3735 is merged, should we close it?

@zhangsoledad
Copy link
Member Author

@chenyukang yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t:enhancement Type: Feature, refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chenyukang @zhangsoledad