code refactor

nervosnetwork · Oct 26, 2023 · c1134f4 · c1134f4
1 parent ebae19a
commit c1134f4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/tx-pool/src/component/orphan.rs b/tx-pool/src/component/orphan.rs
@@ -154,10 +154,10 @@ impl OrphanPool {
         self.limit_size()
     }
 
-    pub fn find_by_previous(&self, tx: &TransactionView) -> Vec<ProposalShortId> {
+    pub fn find_by_previous(&self, tx: &TransactionView) -> Vec<&ProposalShortId> {
         tx.output_pts()
             .iter()
-            .filter_map(|out_point| self.by_out_point.get(out_point).cloned())
+            .filter_map(|out_point| self.by_out_point.get(out_point))
             .flatten()
             .collect::<Vec<_>>()
     }

diff --git a/tx-pool/src/component/tests/orphan.rs b/tx-pool/src/component/tests/orphan.rs
@@ -46,13 +46,13 @@ fn test_orphan_duplicated() {
 
     let txs = orphan.find_by_previous(&tx1);
     assert_eq!(txs.len(), 3);
-    assert!(txs.contains(&tx2.proposal_short_id()));
-    assert!(txs.contains(&tx4.proposal_short_id()));
-    assert!(txs.contains(&tx5.proposal_short_id()));
+    assert!(txs.contains(&&tx2.proposal_short_id()));
+    assert!(txs.contains(&&tx4.proposal_short_id()));
+    assert!(txs.contains(&&tx5.proposal_short_id()));
 
     orphan.remove_orphan_tx(&tx4.proposal_short_id());
     let txs = orphan.find_by_previous(&tx1);
     assert_eq!(txs.len(), 2);
-    assert!(txs.contains(&tx2.proposal_short_id()));
-    assert!(txs.contains(&tx5.proposal_short_id()));
+    assert!(txs.contains(&&tx2.proposal_short_id()));
+    assert!(txs.contains(&&tx5.proposal_short_id()));
 }