Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add rpc method estimate_cycles #180

Merged

Conversation

yangby-cryptape
Copy link
Collaborator

Description

It's too expensive to keep a CKB testnet / mainnet node for debugging.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review January 18, 2024 09:59
quake
quake previously approved these changes Jan 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (ba5545e) 72.33% compared to head (ad946de) 72.22%.

Files Patch % Lines
src/service.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #180      +/-   ##
===========================================
- Coverage    72.33%   72.22%   -0.11%     
===========================================
  Files           25       25              
  Lines         6648     6658      +10     
===========================================
  Hits          4809     4809              
- Misses        1839     1849      +10     
Flag Coverage Δ
unittests 72.22% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quake quake merged commit e5eb012 into nervosnetwork:develop Jan 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants