fix: refresh last state even no proved state #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #172 +/- ##
===========================================
- Coverage 71.43% 71.42% -0.02%
===========================================
Files 25 25
Lines 6511 6512 +1
===========================================
Hits 4651 4651
- Misses 1860 1861 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
quake
previously approved these changes
Dec 30, 2023
yangby-cryptape
force-pushed
the
bugfix/refresh-last-state-even-no-proved-state
branch
from
f3d4bd1
to
ef511bd
Compare
eval-exec
approved these changes
Dec 30, 2023
quake
approved these changes
Dec 30, 2023
yangby-cryptape
deleted the
bugfix/refresh-last-state-even-no-proved-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the light client only refreshes the last state after it has a proved last state.
But, if it has sent a worse state to the light client (worse than saved state), the light client won't ask its last state proof.
The light client should ask it for a new last state.