Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should mark fetching status as timeout when disconnect #159

Conversation

yangby-cryptape
Copy link
Collaborator

Commits

  • fix: should mark fetching status as timeout when disconnect
  • test: reproduce the bug that state is dirty after unexpected disconnection

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f504501) 69.87% compared to head (fef2381) 71.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #159      +/-   ##
===========================================
+ Coverage    69.87%   71.05%   +1.18%     
===========================================
  Files           25       25              
  Lines         6417     6420       +3     
===========================================
+ Hits          4484     4562      +78     
+ Misses        1933     1858      -75     
Flag Coverage Δ
unittests 71.05% <100.00%> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangby-cryptape yangby-cryptape changed the title WIP fix: should mark fetching status as timeout when disconnect Nov 20, 2023
@yangby-cryptape yangby-cryptape marked this pull request as ready for review November 20, 2023 16:09
@quake quake merged commit d027f5a into nervosnetwork:develop Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants