Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove udt name and symbol validation #1562

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

@zmcNotafraid zmcNotafraid commented Jan 10, 2024

Because the omiga inscription defined name and symbol were 255 max bytes, but udt model's name and symbol length validation were small.So remove this validation.

@codecov-commenter
Copy link

Codecov Report

Attention: 213 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (47b8d96) 67.27%.
Report is 192 commits behind head on develop.

❗ Current head 47b8d96 differs from pull request most recent head 6e0495f. Consider uploading reports for the commit 6e0495f to get more accurate results

Files Patch % Lines
app/workers/charts/ckb_hodl_waves_statistic.rb 0.00% 45 Missing ⚠️
.../controllers/api/v2/ckb_transactions_controller.rb 67.56% 24 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 83.67% 24 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
...p/serializers/omiga_inscription_info_serializer.rb 0.00% 14 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/utils/ckb_utils.rb 87.34% 10 Missing ⚠️
...ontrollers/api/v1/omiga_inscriptions_controller.rb 77.14% 8 Missing ⚠️
app/models/concerns/display_cells.rb 92.68% 6 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1562      +/-   ##
===========================================
+ Coverage    66.37%   67.27%   +0.89%     
===========================================
  Files          275      288      +13     
  Lines         7397     7872     +475     
===========================================
+ Hits          4910     5296     +386     
- Misses        2487     2576      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Jan 10, 2024
Merged via the queue into nervosnetwork:develop with commit e789ecc Jan 10, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-508-4 branch January 10, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants