Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 508 #1557

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Issue 508 #1557

merged 5 commits into from
Jan 9, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

@zmcNotafraid zmcNotafraid commented Jan 8, 2024

Omiga inscription feature

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 207 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (56d591a) 67.22%.
Report is 189 commits behind head on develop.

❗ Current head 56d591a differs from pull request most recent head 8faccf5. Consider uploading reports for the commit 8faccf5 to get more accurate results

Files Patch % Lines
app/workers/charts/ckb_hodl_waves_statistic.rb 0.00% 45 Missing ⚠️
.../controllers/api/v2/ckb_transactions_controller.rb 67.56% 24 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 75.00% 17 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
...p/serializers/omiga_inscription_info_serializer.rb 0.00% 14 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/utils/ckb_utils.rb 85.52% 11 Missing ⚠️
...ontrollers/api/v1/omiga_inscriptions_controller.rb 77.14% 8 Missing ⚠️
app/models/concerns/display_cells.rb 92.68% 6 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1557      +/-   ##
===========================================
+ Coverage    66.37%   67.22%   +0.84%     
===========================================
  Files          275      288      +13     
  Lines         7397     7859     +462     
===========================================
+ Hits          4910     5283     +373     
- Misses        2487     2576      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid force-pushed the issue-508 branch 2 times, most recently from 072c2f8 to 6df1af5 Compare January 9, 2024 03:22
Signed-off-by: Miles Zhang <[email protected]>
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Jan 9, 2024
Merged via the queue into nervosnetwork:develop with commit 161b02d Jan 9, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-508 branch January 9, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants