Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue#79 added a new script to process specific block #1029

Closed

Conversation

iamyates
Copy link
Contributor

extract a new method: process_specific_block_by_number
created a new script: lib/ckb_block_node_processor_for_specific_block_number.rb

usage:

usage: ruby lib/ckb_block_node_processor_for_specific_block_number.rb 8274473

Please review , thanks

@codecov-commenter
Copy link

Codecov Report

Base: 66.42% // Head: 66.34% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (f3c1758) compared to base (be6854d).
Patch coverage: 27.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1029      +/-   ##
==========================================
- Coverage   66.42%   66.34%   -0.08%     
==========================================
  Files         167      168       +1     
  Lines        5391     5402      +11     
==========================================
+ Hits         3581     3584       +3     
- Misses       1810     1818       +8     
Impacted Files Coverage Δ
..._block_node_processor_for_specific_block_number.rb 0.00% <0.00%> (ø)
app/models/ckb_sync/new_node_data_processor.rb 95.00% <62.50%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Keith-CY
Copy link
Collaborator

Conflicted

@iamyates
Copy link
Contributor Author

close this PR due to the new implementation strategy.
new PR is: #1038

@iamyates iamyates closed this Oct 20, 2022
@iamyates iamyates deleted the allow_to_process_specific_block branch April 17, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants