Default mime type to application/octet-stream for unrecognized file types #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginazhouhuiwu
changed the title
brentyi
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Thanks @ginazhouhuiwu!! While we're at it, can we add the same logic here?
viser/src/viser/infra/_infra.py
Line 396 in d56be1a
brentyi
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default file type instead of throwing an exception for unrecognized file types. Used in nerfstudio-project/nerfstudio#3220 in order to directly download
.plyfiles.